After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340205 - rows-reordered signal needs some documentation
rows-reordered signal needs some documentation
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTreeView
2.8.x
Other Linux
: Normal normal
: ---
Assigned To: gtktreeview-bugs
gtktreeview-bugs
Depends on:
Blocks:
 
 
Reported: 2006-04-30 15:54 UTC by Murray Cumming
Modified: 2006-05-04 12:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Murray Cumming 2006-04-30 15:54:21 UTC 
The rows-reordered signal is not emitted when rows are reordered via drag-and-drop. This is apparently not a bug:
http://mail.gnome.org/archives/gtk-devel-list/2005-January/msg00103.html
"
rows-reordered is only for reordering the children of
a single node, whereas dnd allows you to move nodes between branches in 
a tree. Therefore intra-tree dnd is implemented as remove+add.
"

I think the signal documentation should say that, and the gtk_tree_view_set_reorderable() documentation should mention it too. Otherwise, the confusion is understandable.
Comment 1 Matthias Clasen 2006-05-01 02:06:00 UTC 
I added some documentation

2006-04-30  Matthias Clasen  <mclasen@localhost.localdomain>

	* gtk/gtktreemodel.c (gtk_tree_model_base_init): Document
	GtkTreeModel signals.
Comment 2 Murray Cumming 2006-05-01 09:49:15 UTC 
That's really wonderful. Thanks.

May I suggest "Is emitted" rather than "Gets emitted". "Gets" is rather coloquial, and not really suitable for written English. I can make that change if you like.
Comment 3 Matthias Clasen 2006-05-01 14:35:14 UTC 
Feel free to correct that, thanks.
Comment 4 Murray Cumming 2006-05-04 12:17:16 UTC 
Done in HEAD. Thanks again.