After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340128 - gnome-doc-utils needs fix from bug 313531
gnome-doc-utils needs fix from bug 313531
Status: RESOLVED FIXED
Product: gnome-doc-utils
Classification: Deprecated
Component: build utils
CVS HEAD
Other opensolaris
: Normal normal
: ---
Assigned To: gnome-doc-utils maintainers
gnome-doc-utils maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-29 17:05 UTC by James Andrewartha
Modified: 2006-12-05 06:15 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
patch changing grep to egrep and removing backslashes (925 bytes, patch)
2006-10-26 16:58 UTC, James Andrewartha
none Details | Review

Description James Andrewartha 2006-04-29 17:05:25 UTC
gnome-doc-utils should grab the latest gnome-autogen.sh from gnome-common to get the fix from bug 313531, which is causing this build failure:
http://jhbuild.bxlug.be/builds/2006-04-29-0005/logs/gnome-doc-utils/#build
Comment 1 Shaun McCance 2006-08-07 20:54:16 UTC
gnome-doc-utils calls gnome-autogen.sh, so if you've updated your gnome-common, it should use that.

The link you provided doesn't go anywhere.  What exactly is the problem?
Comment 2 James Andrewartha 2006-08-08 03:32:08 UTC
gnome-doc-utils ships its own gnome-autogen.sh with the following comment at the top:

# Copied from gnome-common to avoid circular dependency
# Based on revision 1.15, with g-d-u checks removed
Comment 3 James Andrewartha 2006-10-26 16:58:46 UTC
Created attachment 75458 [details] [review]
patch changing grep to egrep and removing backslashes

This patch changes grep to egrep, which works everywhere. Alternatively, the fix in gnome-common is available at http://cvs.gnome.org/viewcvs/gnome-common/macros2/gnome-autogen.sh?r1=1.18&r2=1.19
Comment 4 James Andrewartha 2006-10-28 19:24:51 UTC
Comment on attachment 75458 [details] [review]
patch changing grep to egrep and removing backslashes

Woops, missed a backslash:

Index: gnome-autogen.sh
===================================================================
RCS file: /cvs/gnome/gnome-doc-utils/gnome-autogen.sh,v
retrieving revision 1.1
diff -u -r1.1 gnome-autogen.sh
--- gnome-autogen.sh	1 Apr 2005 00:06:19 -0000	1.1
+++ gnome-autogen.sh	26 Oct 2006 16:57:37 -0000
@@ -228,7 +228,7 @@
     if grep "^AM_GLIB_GNU_GETTEXT" $configure_ac >/dev/null; then
 	want_glib_gettext=true
     fi
-    if grep "^\(AC\|IT\)_PROG_INTLTOOL" $configure_ac >/dev/null; then
+    if egrep "^(AC|IT)_PROG_INTLTOOL" $configure_ac >/dev/null; then
 	want_intltool=true
     fi
     if grep "^PKG_CHECK_MODULES" $configure_ac >/dev/null; then
@@ -358,7 +358,7 @@
 	   fi
 	fi
 
-	if grep "^\(AC\|IT\)_PROG_INTLTOOL" $basename >/dev/null; then
+	if egrep "^(AC|IT)_PROG_INTLTOOL" $basename >/dev/null; then
 	    printbold "Running $INTLTOOLIZE..."
 	    $INTLTOOLIZE --force --copy --automake || exit 1
 	fi
Comment 5 Shaun McCance 2006-11-16 17:03:54 UTC
I've changed the way gnome-doc-utils bootstraps off of itself.  As a result, it is now actually calling the system-installed gnome-autogen.sh from gnome-common.  So this problem should be effectively fixed.
Comment 6 James Andrewartha 2006-12-05 00:23:23 UTC
I don't know whether this should be a new bug, but the bootstrap fails: http://jhbuild.bxlug.be/builds/2006-12-04-0007/logs/gnome-doc-utils/#configure
Comment 7 Shaun McCance 2006-12-05 06:15:36 UTC
I believe that's the issue we're discussing over in bug #376908.