After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 339828 - fdsink should by sync=FALSE
fdsink should by sync=FALSE
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.x
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-26 16:40 UTC by Philippe Rouquier
Modified: 2006-04-28 08:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
patch proposed (499 bytes, patch)
2006-04-26 16:41 UTC, Philippe Rouquier
reviewed Details | Review

Description Philippe Rouquier 2006-04-26 16:40:58 UTC
As all file sink fdsink (like filesink) should have sync property set to FALSE by default.
Comment 1 Philippe Rouquier 2006-04-26 16:41:41 UTC
Created attachment 64335 [details] [review]
patch proposed
Comment 2 Wim Taymans 2006-04-26 17:22:52 UTC
A bold statement, I'm sure someone had a good reason for setting it to TRUE (which is also the default for any sink). Also multifdsink sets sync=TRUE. I guess it depends on the type of socket you use (network vs file).

Also better use gst_base_sink_set_sync().
Comment 3 Philippe Rouquier 2006-04-26 21:01:28 UTC
Actually I was the one who ported fdsink to 0.10.0 and the one who chose to set it to TRUE, though I must admit I didn't really know why.
Now I see two reasons why it might be set to FALSE:
First, to do like filesink (which is a bad reason)
Second, I don't really see the point of syncing when you're not playing and most of the time when you'd use fdsink you would pipe the result to another application or to a file and in this case a clock wouldn't really be required.
But you would surely find me wrong so let's close this bug and sorry for the spam.
The way things are is fine by me.
Comment 4 Wim Taymans 2006-04-28 08:58:53 UTC
Thing is that changing this now would break the behaviour of applications depending on the default synchronisation.

Added some docs to the plugin to note the default synchronisation behaviour. 

Closing this, the workaround is to manually set the sync to FALSE with the "sync" property when needed.