After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 339754 - totem doesnt lock cd-drive
totem doesnt lock cd-drive
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
1.4.x
Other Linux
: Normal enhancement
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 340159 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-04-25 20:53 UTC by Sebastien Bacher
Modified: 2013-03-19 11:19 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14



Description Sebastien Bacher 2006-04-25 20:53:40 UTC
That bug has been opened on https://launchpad.net/distros/ubuntu/+source/totem/+bug/41142

"On todays dapper totem doesnt lock the cd drive when im listening to audio cds. I can press the drives eject button and it ejects the cds, then of course the playback stops.

I would like totem to lock the cd drive so i can only open it when i press the stop button.
...
> Thanks for your bug. Could you argue on why locking the drive would be useful? Do you often press that button by accident? It seems to be an extra step that would rather be annoying for an user than useful...
...
its consistent, when you mount a data cd you have to unmount it before you can eject it to prevent applications that run on or from the cd from crashing

usually you dont put a cd in to listen to just one song, you want to hear most of the songs, then i usually end totem and then i eject the cd

and yes, i hit the cd button quite often with my knee because i cant sit still :-)

thanks for your time!"
Comment 1 Bastien Nocera 2006-05-25 22:15:15 UTC
*** Bug 340159 has been marked as a duplicate of this bug. ***
Comment 2 Bastien Nocera 2006-05-25 22:18:00 UTC
Should we lock or not lock the CD drive?
http://article.gmane.org/gmane.comp.freedesktop.hal/5330
Comment 3 Pozsár Balázs 2006-05-26 18:42:11 UTC
Imho the drive should not be locked, not even for (readonly) data discs. The eject button is there to eject the disc, nothing more, nothing less. If only readonly operations are made to the disc, there's really no reason to lock it, the software/os should handle the eject gracefully. (Even when there's no "ejectpressed" signal from the drive.)
Comment 4 Bastien Nocera 2006-09-22 15:39:39 UTC
I think we should try to:
- always mount the drive (only for VCD/DVD obviously)
- remove from the playlist as soon as it's been umounted (we do that already for files, but not for DVDs)
Comment 5 Bastien Nocera 2013-03-19 11:19:05 UTC
(In reply to comment #4)
> I think we should try to:
> - always mount the drive (only for VCD/DVD obviously)

That's already something that the lower-down levels do for us.

> - remove from the playlist as soon as it's been umounted (we do that already
> for files, but not for DVDs)

And that works correctly in my testing. Probably fixed by this one-liner:

commit c93dbf7a37bc2862dec23245db8cf915ad670a94
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Jul 2 18:56:27 2012 +0100

    main: Fix totem_get_mount_for_dvd() not working
    
    We were checking the retval of g_mount_can_eject() the wrong way
    around, so we never got a mount for the DVD device in question.