After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 339626 - Wrong icons used for trash in mailer UI
Wrong icons used for trash in mailer UI
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
unspecified
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 339572 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-04-24 19:03 UTC by Rodney Dawes
Modified: 2006-04-27 16:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix trash/delete icon issues (4.80 KB, patch)
2006-04-24 19:04 UTC, Rodney Dawes
accepted-commit_now Details | Review

Description Rodney Dawes 2006-04-24 19:03:14 UTC
In some places, the wrong icon is being used as a trash icon, as the stock delete icons in GTK+ are trash cans, but this is not true in all themes. The attached patches fixes the UI to do the following:

Remove the undelete icon from the menu item (it is not in the toolbar)
Update several icons that were using GTK_STOCK_DELETE to use the gnome trash icons

We probably should also change "Delete" to "Move to Trash" in the menus, but I think this can wait, as it breaks string freeze. However, doing this will improve the consistency with Nautilus, and also more directly show the behavior of deleting mail. Delete Folder should still use the delete icon, as it is actually non-recoverable.
Comment 1 Rodney Dawes 2006-04-24 19:04:18 UTC
Created attachment 64227 [details] [review]
Patch to fix trash/delete icon issues
Comment 2 Jeffrey Stedfast 2006-04-24 20:19:47 UTC
*** Bug 339572 has been marked as a duplicate of this bug. ***
Comment 3 Daniel Holbach 2006-04-25 07:19:55 UTC
Discussed in https://launchpad.net/distros/ubuntu/+source/evolution/+bug/31034 as well.
Comment 4 Srinivasa Ragavan 2006-04-27 09:16:02 UTC
dobey: looks fine to commit.
Comment 5 Rodney Dawes 2006-04-27 16:46:54 UTC
Committed to both head and gnome-2-14 branch. Thanks.