GNOME Bugzilla – Bug 339554
Tag Icon not changed when spin button changes in Tag Icon Editor
Last modified: 2011-03-04 03:55:01 UTC
Please describe the problem: When one changes the photo Tag Icon Editor using the spin box, the tag icon at the top is not changed with it. Steps to reproduce: 1. 2. 3. Actual results: Icon not changed on photo change. The Icon is only changed when the photo is clicked on or the selection frame is changed Expected results: The icon changes when the photo changes. Does this happen every time? always Other information:
Created attachment 64193 [details] [review] Changes the tag icon on spin button change
the selection goes away when you change photos though right? I'm pretty sure I left it this way so that you could browse photos without changing the tag.
Are we on the same page? I may not have made myself clear. The little preview at the top is what is not being changed. Of course, the actually tag icon should not changed till OK is clicked. If you are in fact speaking of the preview icon, I don't get why you wouldn't want to see the icon previewed in the smaller format. Often the way the photo looks in the smaller format is far different form the larger. Furthermore, the preview is changed when adjusting the selection box and upon changing the photo with the spinbox the preview is changed to the previous/next photo and then afterwards not changed by the spinbox. So basically it's inconsistant the way it is now. So why have a preview icon if you don't use it while browsing?
Created attachment 97743 [details] [review] updated patch
I agree with Larry. I prefer browsing the pictures before setting it as the icon.
Comment on attachment 97743 [details] [review] updated patch Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this. Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap. Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again. You can filter these mails by searching for ###F-OLDPATCHCLEANUP###