After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 339462 - [PATCH] xvid plugin to support more capabilities of XviD codec
[PATCH] xvid plugin to support more capabilities of XviD codec
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.1
Other Linux
: Normal enhancement
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-23 13:03 UTC by Mark Nauwelaerts
Modified: 2006-05-16 20:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to xvid implementing enhancement (76.17 KB, patch)
2006-04-23 13:09 UTC, Mark Nauwelaerts 		none Details | Review
patch updated to latest release/HEAD (74.68 KB, patch)
2006-05-11 22:17 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2006-04-23 13:03:11 UTC 
XviD codec has more capabilities than are currently exposed in xvid plugins;
e.g. constant quantizer encoding, 2-pass (vbr) encoding and various settings affecting encoding etc.
xvid plugins can be enhanced accordingly in the interest of transcoding.
Comment 1 Mark Nauwelaerts 2006-04-23 13:09:56 UTC 
Created attachment 64145 [details] [review]
patch to xvid implementing enhancement

This patch implements the indicated enhancement(s), specifically:
- adds more properties to xvidenc to control xvid encoding
- some b-frame (delay) effect handling
- re-factoring of the colourspace, caps etc handling
Comment 2 Wim Taymans 2006-05-11 11:10:19 UTC 
can you update the patch to current HEAD? It fails to apply in a non-evident way.
Comment 3 Mark Nauwelaerts 2006-05-11 22:17:36 UTC 
Created attachment 65273 [details] [review]
patch updated to latest release/HEAD
Comment 4 Wim Taymans 2006-05-12 09:29:31 UTC 
Applied. Please check since I did some other cleanups...


        Patch by: Mark Nauwelaerts <manauw at skynet dot be>

        * ext/xvid/gstxvid.c: (gst_xvid_init), (gst_xvid_structure_to_csp),
        (gst_xvid_csp_to_caps), (gst_xvid_image_get_size),
        (gst_xvid_image_fill):
        * ext/xvid/gstxvid.h:
        * ext/xvid/gstxviddec.c: (gst_xviddec_class_init),
        (gst_xviddec_init), (gst_xviddec_reset), (gst_xviddec_unset),
        (gst_xviddec_handle_sink_event), (gst_xviddec_setup),
        (gst_xviddec_add_par), (gst_xviddec_negotiate),
        (gst_xviddec_decode), (gst_xviddec_chain),
        (gst_xviddec_flush_buffers), (gst_xviddec_src_getcaps),
        (gst_xviddec_src_link), (gst_xviddec_setcaps),
        (gst_xviddec_change_state):
        * ext/xvid/gstxviddec.h:
        * ext/xvid/gstxvidenc.c: (gst_xvidenc_profile_get_type),
        (gst_xvidenc_quant_type_get_type), (gst_xvidenc_pass_get_type),
        (gst_xvidenc_get_type), (gst_xvidenc_base_init),
        (gst_xvidenc_class_init), (gst_xvidenc_init),
        (gst_xvidenc_finalize), (gst_xvidenc_handle_sink_event),
        (gst_xvidenc_setup), (gst_xvidenc_setcaps), (gst_xvidenc_encode),
        (gst_xvidenc_chain), (gst_xvidenc_flush_buffers),
        (gst_xvidenc_set_property), (gst_xvidenc_get_property),
        (gst_xvidenc_change_state):
        * ext/xvid/gstxvidenc.h:
        xvid plugin to support more capabilities of XviD codec.
        Fixes #339462.
        Some more cleanups here and there.
Comment 5 Mark Nauwelaerts 2006-05-16 20:43:03 UTC 
I had a look and it checks out fine ...
(and reminds me to make more of an effort regarding coding standards :) )