After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 339366 - [playbin] hangs if suburi file type cannot be determined
[playbin] hangs if suburi file type cannot be determined
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: High major
: 0.10.11
Assigned To: Tim-Philipp Müller
GStreamer Maintainers
: 323255 339492 339942 364560 381162 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-04-22 00:38 UTC by Víctor Daniel
Modified: 2006-12-11 10:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14



Description Víctor Daniel 2006-04-22 00:38:26 UTC
(I do not speak well English  :) 

I have Fedora Core 5 installed in my PC (totem is update):

if I have a text file (txt) in same folder of the average file and these have
the same name (for example, sound.mp3 and sound.txt), Totem Crashes.

I have lame (mp3 plugin) because i update the gstreamer 0.10 from
http://gstreamer.freedesktop.org/pkg/fedora/5/0.10/i386/.
Comment 1 Sergej Kotliar 2006-04-23 11:52:57 UTC
Thanks for the bug report. Without a stack trace from the crash it's very hard to determine what caused it.
Can you provide us with one? Please see http://live.gnome.org/GettingTraces for more information on how to do so.
Comment 2 Tim-Philipp Müller 2006-04-23 12:52:46 UTC
I believe this bug is fixed in both totem (don't check for corresponding subtitle files for audio-only files) and in gst-plugins-base CVS (error out instead of crashing when a subtitle file is added for an audio-only file).
Comment 3 Sergej Kotliar 2006-04-23 20:16:58 UTC
*** Bug 339492 has been marked as a duplicate of this bug. ***
Comment 4 John Thacker 2006-04-24 15:26:37 UTC
Ah, but this bug hits for non audio-only files as well.  It happens for any
type of file, according to my tests.

It's entirely possible that someone might have filename.avi or filename.mpg in a directory, and then filename.txt which contains information about the file but isn't a subtitle file.  It's a lot less likely with all the other extensions, but .txt is common enough that it may certainly be used by a user for things other than subtitle files.

So not checking for subtitle files for audio-only files isn't enough
to fix the problem.
Comment 5 John Thacker 2006-04-24 15:27:37 UTC
Also, with all my tests it's not actually a crash, it's a hang, FWIW.
Comment 6 Sergej Kotliar 2006-04-24 15:40:51 UTC
Well, the devs can probably say if it's not the same bug and reopen the other one, but my gut feeling says that they're the same...
Comment 7 John Thacker 2006-04-24 16:12:43 UTC
Yeah, these are the same bugs.  I was just trying to give a fuller description of what's going on with this one.  The original reporter only noticed it for mp3s, but since it happens for video files as well, it's a bigger problem than just not looking for subtitle files on audio-only files.  To really fix the problem, it needs to not hang when the putative subtitle file isn't really one.
Comment 8 Sergej Kotliar 2006-04-27 21:10:49 UTC
Not sure what other info is needed, reopening. If it is in deed fixed, please close this.
Comment 9 Sergej Kotliar 2006-04-27 21:11:00 UTC
*** Bug 339942 has been marked as a duplicate of this bug. ***
Comment 10 Tim-Philipp Müller 2006-07-04 19:43:19 UTC
With current GStreamer-0.10 CVS playbin seems to hang if the media type of the subtitle file is not recognised. More precisely, it hangs in setup_source() at:

      while (!play_base_bin->subtitle_done)
        GROUP_WAIT (play_base_bin);


Also need to check what happens if:

 * subtitle stream media type is known but not decodable
 * subtitle stream media type is known and decodable and audio and/or video
Comment 11 Tim-Philipp Müller 2006-10-18 09:55:55 UTC
Hang fixed at least for immediate errors:

 2006-10-18  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/playback/gstplaybasebin.c: (setup_source):
          Don't hang forever if the subbin already fails to start up in 
          the state change to PAUSED (#339366).

Still need to handle async errors.
Comment 12 Tim-Philipp Müller 2006-10-18 13:00:42 UTC
Fixed for async errors as well now (and there are no real problems if the suburi file is an audio or video file either):

 2006-10-18  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/playback/gstplaybasebin.c: (subbin_startup_sync_msg),
        (setup_source):
          Catch async errors when starting up the subtitle bin, so we can
          stop waiting and continue with the main film instead of hanging
          forever. Fixes #339366.

        * tests/check/elements/playbin.c: (playbin_suite):
          Enable unit test for the above.

Comment 13 Tim-Philipp Müller 2006-10-24 23:26:01 UTC
*** Bug 364560 has been marked as a duplicate of this bug. ***
Comment 14 Tim-Philipp Müller 2006-10-27 17:18:34 UTC
*** Bug 323255 has been marked as a duplicate of this bug. ***
Comment 15 Tim-Philipp Müller 2006-12-11 10:51:31 UTC
*** Bug 381162 has been marked as a duplicate of this bug. ***