GNOME Bugzilla – Bug 339292
[Patch] Use po/LINGUAS - based on the NEW guidelines
Last modified: 2006-12-22 22:36:55 UTC
This patch is based on the NEW guidelines (http://live.gnome.org/GnomeGoals/PoLinguas). It's a diff against current CVS HEAD.
Created attachment 64038 [details] [review] Proposed patch
Since it requires a CVS version of INTTOOLS, it probably shouldn't be applied until there is an official release that is also widely available in various distro's repositories, otherwise it imposes an unnecessary burden on those testing the CVS version of rhythmbox. It's also an easy patch to apply later on, and the current version works well enough.
Created attachment 65519 [details] [review] Updated patch - intltool 0.35.0 released
Actually the following patch also would work as a temporary solution, as I posted to devel list, without waiting for a new intltool release: Index: configure.ac =================================================================== RCS file: /cvs/gnome/rhythmbox/configure.ac,v retrieving revision 1.256 diff -u -p -d -r1.256 configure.ac --- configure.ac 2 Sep 2006 13:41:13 -0000 1.256 +++ configure.ac 26 Sep 2006 09:59:01 -0000 @@ -649,7 +649,7 @@ GETTEXT_PACKAGE=rhythmbox AC_SUBST(GETTEXT_PACKAGE) AC_SUBST([CONFIG_STATUS_DEPENDENCIES],['$(top_srcdir)/po/LINGUAS']) AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE, "$GETTEXT_PACKAGE", [Define to the Gettext package name]) -ALL_LINGUAS="`cat "$srcdir/po/LINGUAS" | grep -v '^#'`" +ALL_LINGUAS="`cat "$srcdir/po/LINGUAS" | grep -v '^#' | xargs`" AM_GLIB_GNU_GETTEXT
Isn't this patch (attachment #65519 [details]) ok to be commited?
Committed to cvs (with updates for any new locales).