GNOME Bugzilla – Bug 339259
[Patch] Use po/LINGUAS and intltool
Last modified: 2008-10-06 11:58:20 UTC
This patch is based on the new guidelines (http://live.gnome.org/GnomeGoals/PoLinguas). It adds po/LINGUAS file and intltool support.
Created attachment 64006 [details] [review] Proposed patch
Created attachment 65522 [details] [review] Updated patch - intltool 0.35.0 released
I don't like the dependency on 0.35.0 intltool, is that absolutely necessary?
Since atk is a dependency of gtk+, I think maybe we should wait to do this when glib/gtk+ do it, otherwise someone building gtk+ will still encounter the intltool dependency.
I am marking this bug as dependent on 344383, since atk is a dependency of gtk+. If we apply the patch to atk, we'll be forcing the issue raised in 344383, so I'd rather wait for the gtk+ team here. In order to flag the fact that we're in a "holding pattern" with respect to this patch, I am also marking the bug 'NEEDINFO', though the only info we really need is knowing whether/when gtk+ plans to adopt the new PO strategy. If the gtk+ plans to reject the patch indefinitely, then we too should IMO close as WONTFIX. Personally I don't have an objection to the patch appearing in HEAD, but I think we should be mindful of the impact on gtk+ (If we get a solution to the circular dependency issue for glib/intltool then it seems reasonable to me to use LINGUAS for everything at glib and above)
Changing from 'minor' severity to 'enhancement' and leaving NEEDINFO (really should be BLOCKED bug we don't have a bugzilla status for that I guess)
Created attachment 112719 [details] [review] Use po/LINGUAS without dependency on intltool patch based on the one used for glib and proposed for gtk.
Bug 344383 has been fixed, this is the LAST GNOME MODULE waiting to get fixed. Bill, can you please review and commit?
ping :)
I should review the patch but I am not in the cc list. After applying the patch, I got error when "make dist". cp: `./af.po' and `/home/liyuan/src/atk/atk-1.23.5/po/af.po' are the same file ...... ...... ...... cp: `./zh_CN.gmo' and `/home/liyuan/src/atk/atk-1.23.5/po/zh_CN.gmo' are the same file cp: `./zh_HK.gmo' and `/home/liyuan/src/atk/atk-1.23.5/po/zh_HK.gmo' are the same file cp: `./zh_TW.gmo' and `/home/liyuan/src/atk/atk-1.23.5/po/zh_TW.gmo' are the same file make[1]: *** [distdir] Error 1 make[1]: Leaving directory `/home/liyuan/src/atk/po' make: *** [distdir] Error 1
Hmm.... Thomas, any idea?
Thomas, any idea?
Li Yuan committed the patch in bug #551474 (rev 1272) so this bug can be closed now. I hope I don't step on anybodies toes when I change status on bugs in others modules. If I do just let me know and I will stop doing that.