After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 339214 - move reset of caps-nego from ready->pause to pause->ready
move reset of caps-nego from ready->pause to pause->ready
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-20 19:03 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2006-05-09 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
move the caps-nego (828 bytes, patch)
2006-04-20 19:06 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		reviewed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2006-04-20 19:03:50 UTC 
Attached is tiny patch where the resetting of caps nego flag is moved from "ready->pause" state change to "pause->ready" state change.

This is because when streaming e.g. audio files, the caps nego is done after the basetransform element is created and when it goes to play state (through pause), the caps flag was reset.

Do you think that moving the reset of the flag between the state changes could cause any problems?
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2006-04-20 19:06:47 UTC 
Created attachment 63988 [details] [review]
move the caps-nego

patch by: Antti Viinikka
Comment 2 Wim Taymans 2006-04-21 16:34:15 UTC 
I can't see how this would help, no dataflow is supposed to happen in READY anyway. Are you sure you are not feeding data to the element in the READY state?

The later does not currently fail in core because new pads are not set to the flushing state (this is a bug we cannot fix yet due to a lot of regressions, see #339326).
Comment 3 Tim-Philipp Müller 2006-05-08 10:46:50 UTC 
Ping?
Comment 4 Tommi Myöhänen 2006-05-09 12:59:34 UTC 
The element is now put to pause state before dataflow is started, so the
patch is now obsolete and original problem doesn't occur anymore.