After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 339143 - Search should be a toolbar
Search should be a toolbar
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: User Interface
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-20 09:56 UTC by Amadeus
Modified: 2012-03-28 21:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Mock up of the search entry and buttons centered (like the info info is) and made to look like a toolbar. (77.01 KB, image/png)
2006-04-20 09:58 UTC, Amadeus
Details
"Titles" got cut away by a mistake in the previous mock up. (77.33 KB, image/png)
2006-04-20 10:08 UTC, Amadeus
Details

Description Amadeus 2006-04-20 09:56:24 UTC
I think the search should be a toolbar for these reasons:

* Buttons and time slider are/looks like toolbars. (Keep in style)
* It will align Soruces, Artist, and Album
* It could be made togglable in View.
* It will resolve Bug #335812
Comment 1 Amadeus 2006-04-20 09:58:25 UTC
Created attachment 63930 [details]
Mock up of the search entry and buttons centered (like the info info is) and made to look like a toolbar.
Comment 2 Amadeus 2006-04-20 10:08:24 UTC
Created attachment 63932 [details]
"Titles" got cut away by a mistake in the previous mock up.
Comment 3 William Jon McCann 2006-04-20 14:04:31 UTC
So, don't like the clearlooks theme huh? ;)

To address your points.

* The search bar is already partly a GtkToolbar. 
* The search bar doesn't search through sources so it seems a little misleading to locate it over the source list.  The way it is now it is clear that it searches through all the items under it.
* You could toggle its visibility the way it is now.  However, I still maintain that hiding the search entry on a search-based interface is just crazy.
* There is a more direct way of fixing bug #335812 :)

But overall I don't think this provides any real benefit over what we have.
Comment 4 Amadeus 2006-04-20 15:16:49 UTC
> So, don't like the clearlooks theme huh? ;)

Busted =)

> * The search bar is already partly a GtkToolbar. 

I primary think from an UI point of view. The first two have the width of the entire UI, but the Search doesn't. I think this is out of style.

> * The search bar doesn't search through sources so it seems a little
>   misleading to locate it over the source list.  The way it is now it is
>   clear that it searches through all the items under it.

I see your point, but after the All, Artist, Album, and Title search buttons were added, I think it is quite clear where the search will be carried out.

> * There is a more direct way of fixing bug #335812 :)

But it is good PR for this bug =)
Comment 5 Jonathan Matthew 2012-03-28 21:29:46 UTC
I don't even know what this bug is asking for any more.