GNOME Bugzilla – Bug 338912
Find Next/Previous wrap around even when wrapping is off
Last modified: 2006-04-25 09:24:48 UTC
Forwarded from: https://launchpad.net/distros/ubuntu/+source/gedit/+bug/39991 gedit 2.14.2, Ubuntu Dapper 1. Enter "A man, a plan, a canal, Panama" in a new document. 2. Go to the start of the document (Ctrl+Home). 3. Open the Find dialog, enter "a " as the search string, and turn "Wrap around" off. 4. Click "Find" repeatedly. It highlights the three occurrences, and stop at the last one. 5. Close the dialog. 6. Choose "Find Next". What should happen: * Nothing, because the last occurrence is already selected. What actually happens: * Find Next and Find Previous behave as if "Wrap around" was still turned on.
Created attachment 63977 [details] [review] Patch v.1
The patch looks ok to me codewise. I just wonder if the interaction with the interactive search is correct: - search with the dialog and set wrap around off - close dialog - search with ctrl+k - use find next -> it will search the interactive search word with wrap around off However I don't see any nice way to handle this, so I am ok with the patch.
pbor: When we discussed the problem we decided to have a different set of preferences for interactive search and dialog-based search. Committing the patch to CVS HEAD. Do you think we should commit it to gnome-2-14 too? It seems quite safe to me.
we decided to independent preferences for the dialog and ctrl+k, but find next is nor a dialog nor a ctrl+k thing: it's "find again what was searched last time both if it was with a dialog or with ctrl+K". That said, ok, I will apply to 2.14 too :)