After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338910 - scroll bar obscured in fullscreen mode
scroll bar obscured in fullscreen mode
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
0.5.x
Other Linux
: Normal minor
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-18 16:41 UTC by Daniel Holbach
Modified: 2007-04-20 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Move fullscreen toolbar into main window (11.16 KB, patch)
2006-06-03 00:16 UTC, Pat Rondon
none Details | Review

Description Daniel Holbach 2006-04-18 16:41:10 UTC
Forwarded from: https://launchpad.net/distros/ubuntu/+source/evince/+bug/40000

in fullscreen mode (view fullscreen) the top of the scroll bar is obscured by the tool bar.

evince 0.5.2
Comment 1 Sergej Kotliar 2006-04-18 19:56:47 UTC
Yeah, confirming.
Comment 2 Pat Rondon 2006-06-03 00:16:10 UTC
Created attachment 66683 [details] [review]
Move fullscreen toolbar into main window

Move the fullscreen toolbar into the main window, ensuring that it never obscures the view.
Comment 3 Martin Kretzschmar 2006-06-03 08:26:34 UTC
IIRC it wasn't made part of the main window, so that the document view doesn't move/resize when the toolbar appears/disappears, which would be quite irritating when reading in fullscreen mode. Does it do that with the patch? (Sorry, I should just try, but ...)
Comment 4 Nickolay V. Shmyrev 2006-06-03 17:29:19 UTC
Although this will fix 338871, there is much more important bug 300278. I am willing to accept this patch since it will solve page entry problem even if it will resize document. Martin, what do you think?

Nice patch btw, thanks Pat.
Comment 5 Pat Rondon 2006-06-04 00:40:35 UTC
(In reply to comment #3)
> IIRC it wasn't made part of the main window, so that the document view doesn't
> move/resize when the toolbar appears/disappears, which would be quite
> irritating when reading in fullscreen mode. Does it do that with the patch?
> (Sorry, I should just try, but ...)

Yes, it does that.  It didn't strike me as an irritating change, since it only occurs while you're making adjustments - at least, it seems less irritating than not being able to use the top of the scroll bar at all. ;-)  It seems a worthwhile tradeoff to fix three bugs in one shot.
Comment 6 Pat Rondon 2006-06-04 04:59:05 UTC
I'd also like to note that the resizing isn't necessarily irritating and can actually be helpful.  Suppose the document is set to fit so that it fills the view vertically and that some piece of information useful for navigating is at the top of each page.  As it is, the top of the page will be obscured by the toolbar, making it hard to use the information on the top of the page when navigating via the toolbar.
Comment 7 Malte 2007-02-25 14:06:51 UTC
Setting myself on the CC list, I'd like to subscribe to comment #6. Actually I was going to submit a bug report about the top of the page being hidden by the toolbar in fullscreen mode. Is this issue considered by those who (will) work on this ticket?
Comment 8 Nickolay V. Shmyrev 2007-02-25 22:35:33 UTC
(In reply to comment #7)
> Setting myself on the CC list, I'd like to subscribe to comment #6. Actually I
> was going to submit a bug report about the top of the page being hidden by the
> toolbar in fullscreen mode. Is this issue considered by those who (will) work
> on this ticket?
> 

Hm, it should be separate problem, doesn't it disappear after some delay?
Comment 9 Malte 2007-03-01 18:11:15 UTC
(In reply to comment #8)
> Hm, it should be separate problem, doesn't it disappear after some delay?

It does, but this behavior does not fit me. Imagine one thinking, “What chapter am I currently looking at? Let's look at the head of the page and find out!” If one then uses the mouse for scrolling or dragging, one has to wait a couple of seconds - which is annoying. I'm not sure whether to file a seperate bug report because I do not understand the effect of the proposed patch. I'll probably file it anyway.
Comment 10 Nickolay V. Shmyrev 2007-03-01 23:54:04 UTC
Well, I agree it's annoying sometimes, but you probably should take into account that we can't show toolbar forever and we have to zoom window if we'd like avoid overlapping. So there is no optimal solution yet
Comment 11 Carlos Garcia Campos 2007-03-02 10:13:44 UTC
(In reply to comment #10)
> we can't show toolbar forever 

why not? ephy, galeon and firefox do that, for instance. Talking on IRC the other day, clarkbw said he agreed on keeping toolbar always visible in fullscreen mode, and he also proposed to add a button to switch to presentation mode. Here is the mockup clarkbw did:

http://www.gnome.org/~clarkbw/designs/document-viewer/evince-fullscreen-small.png

By keeping toolbar always visible we would fix three bugs in a shoot. I think it's worth. The problem is that we are frozen right now, so we'll have to do it during the next release cycle. 

Comment 12 Nickolay V. Shmyrev 2007-03-02 21:10:23 UTC
Well, I am not strongly advocating moving toolbar. Let's make it always visible
Comment 13 Carlos Garcia Campos 2007-04-20 13:24:25 UTC
Finally fixed in svn trunk.