GNOME Bugzilla – Bug 338730
PO LINGUAS - GNOME Goal
Last modified: 2006-12-20 00:34:39 UTC
See http://live.gnome.org/GnomeGoals/PoLinguas.
Created attachment 63657 [details] [review] Makes configure.in changes
Created attachment 63658 [details] po/LINGUAS File to be added.
Looks cool, but by making this change we will no longer be able to compile on almost any distro anywhere. This is what's stated on the page: 'Please note that you will need the CVS version (soon to be released as 0.35) of intltool to achieve this goal.'
Autogen outputs this instead of failing on my machine. checking for intltool >= 0.34.90... 0.34.2 found
That's strange... If it does in fact work (ie: The LINGUAS are actually being pulled in properly with an older version of intltool) then I'd say it's good to go.
I tested make dist and the po files aren't included in the tarball. I have upgraded to intltool from cvs and ammended the LINGUAS file to remove the no locale from the list. make dist now includes the po files properly. I think because 0.9.x is a development series we have some leeway on requiring an update to the next development versions for GNOME. I'll attach an updated patch and LINGUAS file.
Created attachment 64288 [details] po/LINGUS: removed 'no' locale
Created attachment 64289 [details] [review] updated to include intltool 0.35 release
(In reply to comment #6) > I think because 0.9.x is a development series we have some leeway on requiring > an update to the next development versions for GNOME. So far in CVS HEAD we've tried to remain compatible with the last two versions at least. We don't have many developers, users. We shouldn't alienate them by depending on something that isn't even in a release yet. In any case, have you seen the posts desktop-devel-list? Like 4 or 5 brown paper bag releases in the GNOME 2.15.x release set due to this whole LINGUAS 'Goal' not being thought out properly and rushed.
(In reply to comment #9) > So far in CVS HEAD we've tried to remain compatible with the last two versions > at least. We don't have many developers, users. We shouldn't alienate them by > depending on something that isn't even in a release yet. Good enough, but we should keep the patch around. In any case, AC_PROG_INTLTOOL has been deprecated. > In any case, have you seen the posts desktop-devel-list? Like 4 or 5 brown > paper bag releases in the GNOME 2.15.x release set due to this whole LINGUAS > 'Goal' not being thought out properly and rushed. I have been paying attention to the list and it seems like people weren't using gnome-autogen.sh or hadn't updated their intltool install.
Comment on attachment 64289 [details] [review] updated to include intltool 0.35 release >Index: configure.in >=================================================================== >RCS file: /cvs/gnome/seahorse/configure.in,v >retrieving revision 1.105 >diff -u -d -b -w -r1.105 configure.in >--- configure.in 21 Apr 2006 00:00:57 -0000 1.105 >+++ configure.in 25 Apr 2006 21:25:45 -0000 >@@ -25,7 +25,7 @@ > AM_CONFIG_HEADER(config.h) > AM_MAINTAINER_MODE > >-AC_PROG_INTLTOOL >+IT_PROG_INTLTOOL([0.35.0]) > AM_PROG_LIBTOOL > AM_GCONF_SOURCE_2 > GNOME_DOC_INIT >@@ -673,8 +673,6 @@ > dnl ******************* > dnl ***** gettext ***** > dnl ******************* >- >-ALL_LINGUAS="az bg ca cs da de en_CA en_GB es eu fi fr hr hu it ja ml ms nb ne nl pa pl pt pt_BR ru rw sk sl sq sr sr@Latn sv tr uk zh_CN zh_TW" > > GETTEXT_PACKAGE=seahorse > AC_SUBST(GETTEXT_PACKAGE)
It's already safe to depend on intltool 0.35.0. Shouldn't this patch be applied?
2006-12-19 Adam Schreiber <sadam@clemson.edu> * configure.in: * po/LINGUAS(added): GNOME PO LINGUAS goal. Fixes #338730 The po files are in the tarball now.