After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338730 - PO LINGUAS - GNOME Goal
PO LINGUAS - GNOME Goal
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: 1.0.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2006-04-16 19:54 UTC by Adam Schreiber
Modified: 2006-12-20 00:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Makes configure.in changes (772 bytes, patch)
2006-04-16 19:55 UTC, Adam Schreiber
reviewed Details | Review
po/LINGUAS (182 bytes, application/octet-stream)
2006-04-16 19:56 UTC, Adam Schreiber
  Details
po/LINGUS: removed 'no' locale (179 bytes, application/octet-stream)
2006-04-25 21:27 UTC, Adam Schreiber
  Details
updated to include intltool 0.35 release (756 bytes, patch)
2006-04-25 21:28 UTC, Adam Schreiber
reviewed Details | Review

Description Adam Schreiber 2006-04-16 19:54:18 UTC
See http://live.gnome.org/GnomeGoals/PoLinguas.
Comment 1 Adam Schreiber 2006-04-16 19:55:53 UTC
Created attachment 63657 [details] [review]
Makes configure.in changes
Comment 2 Adam Schreiber 2006-04-16 19:56:29 UTC
Created attachment 63658 [details]
po/LINGUAS

File to be added.
Comment 3 Stef Walter 2006-04-16 20:58:09 UTC
Looks cool, but by making this change we will no longer be able to compile on almost any distro anywhere. 

This is what's stated on the page: 'Please note that you will need the CVS version (soon to be released as 0.35) of intltool to achieve this goal.'
Comment 4 Adam Schreiber 2006-04-16 21:25:05 UTC
Autogen outputs this instead of failing on my machine.

checking for intltool >= 0.34.90... 0.34.2 found
Comment 5 Stef Walter 2006-04-16 21:52:24 UTC
That's strange... 

If it does in fact work (ie: The LINGUAS are actually being pulled in properly with an older version of intltool) then I'd say it's good to go. 
Comment 6 Adam Schreiber 2006-04-25 21:26:22 UTC
I tested make dist and the po files aren't included in the tarball.  I have upgraded to intltool from cvs and ammended the LINGUAS file to remove the no locale from the list.  make dist now includes the po files properly.

I think because 0.9.x is a development series we have some leeway on requiring an update to the next development versions for GNOME. 

I'll attach an updated patch and LINGUAS file.
Comment 7 Adam Schreiber 2006-04-25 21:27:21 UTC
Created attachment 64288 [details]
po/LINGUS: removed 'no' locale
Comment 8 Adam Schreiber 2006-04-25 21:28:07 UTC
Created attachment 64289 [details] [review]
updated to include intltool 0.35 release
Comment 9 Stef Walter 2006-04-26 00:06:44 UTC
(In reply to comment #6)
> I think because 0.9.x is a development series we have some leeway on requiring
> an update to the next development versions for GNOME. 

So far in CVS HEAD we've tried to remain compatible with the last two versions at least. We don't have many developers, users. We shouldn't alienate them by depending on something that isn't even in a release yet. 

In any case, have you seen the posts desktop-devel-list? Like 4 or 5 brown paper bag releases in the GNOME 2.15.x release set due to this whole LINGUAS 'Goal' not being thought out properly and rushed. 

Comment 10 Adam Schreiber 2006-04-26 01:02:21 UTC
(In reply to comment #9)
> So far in CVS HEAD we've tried to remain compatible with the last two versions
> at least. We don't have many developers, users. We shouldn't alienate them by
> depending on something that isn't even in a release yet. 

Good enough, but we should keep the patch around.  In any case, AC_PROG_INTLTOOL has been deprecated.

> In any case, have you seen the posts desktop-devel-list? Like 4 or 5 brown
> paper bag releases in the GNOME 2.15.x release set due to this whole LINGUAS
> 'Goal' not being thought out properly and rushed. 

I have been paying attention to the list and it seems like people weren't using gnome-autogen.sh or hadn't updated their intltool install.

Comment 11 Adam Schreiber 2006-05-15 16:39:02 UTC
Comment on attachment 64289 [details] [review]
updated to include intltool 0.35 release

>Index: configure.in
>===================================================================
>RCS file: /cvs/gnome/seahorse/configure.in,v
>retrieving revision 1.105
>diff -u -d -b -w -r1.105 configure.in
>--- configure.in	21 Apr 2006 00:00:57 -0000	1.105
>+++ configure.in	25 Apr 2006 21:25:45 -0000
>@@ -25,7 +25,7 @@
> AM_CONFIG_HEADER(config.h)
> AM_MAINTAINER_MODE
> 
>-AC_PROG_INTLTOOL
>+IT_PROG_INTLTOOL([0.35.0])
> AM_PROG_LIBTOOL
> AM_GCONF_SOURCE_2
> GNOME_DOC_INIT
>@@ -673,8 +673,6 @@
> dnl *******************
> dnl ***** gettext *****
> dnl *******************
>-
>-ALL_LINGUAS="az bg ca cs da de en_CA en_GB es eu fi fr hr hu it ja ml ms nb ne nl pa pl pt pt_BR ru rw sk sl sq sr sr@Latn sv tr uk zh_CN zh_TW"
> 
> GETTEXT_PACKAGE=seahorse
> AC_SUBST(GETTEXT_PACKAGE)
Comment 12 Lucas Rocha 2006-12-19 22:33:31 UTC
It's already safe to depend on intltool 0.35.0. Shouldn't this patch be applied?
Comment 13 Adam Schreiber 2006-12-20 00:34:39 UTC
2006-12-19  Adam Schreiber  <sadam@clemson.edu>

    * configure.in:
    * po/LINGUAS(added): GNOME PO LINGUAS goal. Fixes #338730

The po files are in the tarball now.