GNOME Bugzilla – Bug 338715
[shout2send] fix crash on error and tags received before connection is made
Last modified: 2006-04-17 19:59:45 UTC
This patch fixes the bug I reported #338636 And removes a bug which makes metadata not sent if the tag event is received before the connection
Created attachment 63648 [details] [review] The patch
*** Bug 338636 has been marked as a duplicate of this bug. ***
A working pipeline would be gst-launch audiotestsrc ! lame bitrate=128 ! shout2send ip=127.0.0.1 protocol=3 mount=test password=hackme And a non working one which would lead to sigsegv is : gst-launch audiotestsrc ! lame bitrate=128 ! shout2send ip=127.0.0.1 protocol=3 mount=test password=hackme1
Should be fixed in CVS now, thanks for the patch. 2006-04-17 Tim-Philipp Müller <tim at centricular dot net> Patch by: Philippe Valembois * ext/shout2/gstshout2.c: (gst_shout2send_init), (gst_shout2send_set_metadata), (gst_shout2send_event), (gst_shout2send_render), (gst_shout2send_change_state): * ext/shout2/gstshout2.h: Handle tags being received before the connection to the server is established properly (see #338636). 2006-04-17 Tim-Philipp Müller <tim at centricular dot net> * ext/shout2/gstshout2.c: (gst_shout2send_render): Don't crash in case the connection to the server fails: don't set pointer to NULL by assigning FALSE; error out properly by using GST_ELEMENT_ERROR and returning GST_FLOW_ERROR (fixes #338636). Lastly, free connection before resetting the pointer. FWIW, this element seriously needs a rewrite.