After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338657 - [patch] adder should send events from src-pad to all sink-pads
[patch] adder should send events from src-pad to all sink-pads
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.7
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-15 22:23 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2006-04-28 20:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix the problem (3.82 KB, patch)
2006-04-18 17:49 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2006-04-15 22:23:40 UTC 
adder is using gst_pad_event_default_dispatch(), it should override this to send events to add sink pads.


gstbin.c(1918):gst_bin_send_event:<audio_sink_0x81384c8> Sending seek event to sink children
DEBUG (0x8052228 - 0:00:04.214229000)     GST_ELEMENT_PADS(23709) gstelement.c(1206):gst_element_send_event: send seek event on element player
DEBUG (0x8052228 - 0:00:04.214600000)            GST_EVENT(23709) gstpad.c(3765):gst_pad_send_event: have event type seek on pad sink:proxypad1
DEBUG (0x8052228 - 0:00:04.214867000)            GST_EVENT(23709) gstpad.c(3765):gst_pad_send_event: have event type seek on pad audioconvert_0x81384c8:src
DEBUG (0x8052228 - 0:00:04.215134000)            GST_EVENT(23709) gstpad.c(3765):gst_pad_send_event: have event type seek on pad adder_0x81384c8:src
LOG   (0x8052228 - 0:00:04.215312000)             GST_PADS(23709) gstpad.c(2769):gst_pad_event_default_dispatch:<adder_0x81384c8:src> sending event 0x81507e0 (seek) to one sink pad adder_0x81384c8:sink0
DEBUG (0x8052228 - 0:00:04.215511000)            GST_EVENT(23709) gstpad.c(3765):gst_pad_send_event: have event type seek on pad output_gain_0x813ff88:src
DEBUG (0x8052228 - 0:00:04.215754000)            GST_EVENT(23709) gstpad.c(3765):gst_pad_send_event: have event type seek on pad beep1_0x813ff88:src
DEBUG (0x8052228 - 0:00:04.216056000)              basesrc(23709) gstbasesrc.c(761):gst_base_src_perform_seek:<beep1_0x813ff88> doing seek
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2006-04-18 06:08:57 UTC 
fixed locally
Comment 2 Wim Taymans 2006-04-18 11:07:13 UTC 
indeed, as read from the documentation of gst_pad_event_default:

* Note that if there are many possible sink
* pads that are internally linked to @pad, only one will be sent an event.
* Multi-sinkpad elements should implement custom event handlers.

You can post the patch here, I you want.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2006-04-18 17:49:08 UTC 
Created attachment 63809 [details] [review]
fix the problem
Comment 4 Tim-Philipp Müller 2006-04-28 20:34:11 UTC 
Doesn't the patch leak the event in the end, ie. shouldn't there also be 

  gst_event_unref (event)

at the end of gst_adder_src_event()?