After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338440 - bookmarks that describe a view not displayed correctly
bookmarks that describe a view not displayed correctly
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
0.5.x
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-14 09:09 UTC by Roderich Schupp
Modified: 2006-08-06 18:12 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
PDF from bug report (37.50 KB, application/pdf)
2006-04-14 09:11 UTC, Roderich Schupp
  Details
screenshot of Acrobat reader (264.04 KB, image/png)
2006-04-14 09:14 UTC, Roderich Schupp
  Details
screenshot of evince (113.23 KB, image/png)
2006-04-14 09:15 UTC, Roderich Schupp
  Details
screenshot of Acrobat reader (195.21 KB, image/png)
2006-04-14 09:17 UTC, Roderich Schupp
  Details
screenshot of evince (134.07 KB, image/png)
2006-04-14 09:17 UTC, Roderich Schupp
  Details
Proposed patch (1.69 KB, patch)
2006-05-09 18:36 UTC, Carlos Garcia Campos
reviewed Details | Review
New patch (7.29 KB, patch)
2006-08-06 14:51 UTC, Carlos Garcia Campos
none Details | Review
Another patch (7.98 KB, patch)
2006-08-06 15:48 UTC, Carlos Garcia Campos
committed Details | Review

Description Roderich Schupp 2006-04-14 09:09:59 UTC
Please describe the problem:
When choose one of the bookmarks (other than "Full page") from
http://www.sfgate.com/traveler/acrobat/maps/1998/sfcity02.pdf
the view is wrong. This PDF consists of a single page and the
bookmarks represent different points of interest.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Roderich Schupp 2006-04-14 09:11:33 UTC
Created attachment 63442 [details]
PDF from bug report
Comment 2 Roderich Schupp 2006-04-14 09:14:41 UTC
Created attachment 63443 [details]
screenshot of Acrobat reader 

screenshot of Acrobat reader showing bookmark "Chinatown / Financial Dist"
(looks correct to me)
Comment 3 Roderich Schupp 2006-04-14 09:15:46 UTC
Created attachment 63444 [details]
screenshot of evince

screenshot of evince for bookmark "Chinatown / Financial Dist"
Comment 4 Roderich Schupp 2006-04-14 09:17:03 UTC
Created attachment 63445 [details]
screenshot of Acrobat reader 

screenshot of Acrobat reader for bookmark "City Hall / Civic Ctr"
Comment 5 Roderich Schupp 2006-04-14 09:17:36 UTC
Created attachment 63446 [details]
screenshot of evince

screenshot of evince for bookmark "City Hall / Civic Ctr"
Comment 6 Sergej Kotliar 2006-04-14 11:37:23 UTC
Hmm... Yeah, seeing this too, Evince 0.5.1, poppler 0.5.1.

XPDF seems to handle this correctly, but KPDF seems to have the same problem... Poppler bug perhaps?
Comment 7 Alan Horkan 2006-04-20 15:40:16 UTC
(In reply to comment #6)
> Hmm... Yeah, seeing this too, Evince 0.5.1, poppler 0.5.1.

taking comment as confirmation and marking this as New

Comment 8 Carlos Garcia Campos 2006-05-09 18:36:43 UTC
Created attachment 65104 [details] [review]
Proposed patch

This patch fixes the problem.
Comment 9 Nickolay V. Shmyrev 2006-05-13 10:37:45 UTC
I prefer to get correct coordinate system from poppler. As I understand we use top-left origin while poppler uses bottom-left. But we should not convert coordinate system in the view and probably this should be more documented.
Comment 10 Carlos Garcia Campos 2006-08-06 14:51:25 UTC
Created attachment 70317 [details] [review]
New patch

Here is an updated patch that converts from PDF style coordinates to X style in the PDF backend
Comment 11 Carlos Garcia Campos 2006-08-06 15:48:55 UTC
Created attachment 70320 [details] [review]
Another patch

There is a minor problem in my previous patch. Here is a new one that fixes this problem.
Comment 12 Carlos Garcia Campos 2006-08-06 18:12:47 UTC
2006-08-06  Carlos Garcia Campos  <carlosgc@gnome.org>

        * pdf/ev-poppler.cc: (ev_link_dest_from_dest), (ev_link_from_action),
        (build_tree), (pdf_document_links_get_links),
        (pdf_document_links_find_link_dest):
        * shell/ev-view.c: (goto_fitr_dest), (goto_fith_dest),
        (goto_xyz_dest):

        Convert from PDF style coordinates to X style coordinates in the
        backend rather than in the view. Fixes bug #338440