After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338419 - Regression in the handling of files with multiple audio/subtitle streams
Regression in the handling of files with multiple audio/subtitle streams
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-14 05:02 UTC by Jan Schmidt
Modified: 2006-04-22 21:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix regression in multiple-stream scenario (1006 bytes, patch)
2006-04-14 05:04 UTC, Jan Schmidt
none Details | Review

Description Jan Schmidt 2006-04-14 05:02:36 UTC
I just discovered a file that refuses to preroll properly in playbin. After investigating, it turns out that the file has 2 audio tracks. 

Decodebin relies on pad_probes to detect data passing each decoder source pad. In this case, the 2nd audio track never triggers the pad probe because it never outputs a buffer. Instead, it is just performing a buffer-alloc and discovering that downstream is not linked (It is not the selected track and the StreamSelector is returning not-linked)

There are 2 solutions:
1) Get decodebin to also detect an attempt at buffer-allocation and mark that pad as prerolled. pad_probes do not get called for buffer-alloc, so this will either need core changes, or decodebin needs changing to block the pads instead.
2) Restore the old behaviour of StreamSelector to always perform a fallback buffer-allocation, even for non-selected pads. 

Since 2) is less intrusive, and fixes the regression, attaching a patch for that.
Comment 1 Jan Schmidt 2006-04-14 05:04:34 UTC
Created attachment 63428 [details] [review]
fix regression in multiple-stream scenario
Comment 2 Thomas Vander Stichele 2006-04-22 21:15:10 UTC
commited to CVS