GNOME Bugzilla – Bug 338412
f-spot-import window should remember its position and size
Last modified: 2007-08-16 19:44:14 UTC
Please make the import dialog remember its size, position and arrangement. It is very annoying to resize it each time, especially on high resolutions! :) thanks (And f-spot is shaping up very nicely, kudos, I am starting to like it quite a bit!)
Possibly a different bug, but it should also remember what directory it last imported from.
Related comments in bug #326328
Created attachment 73296 [details] [review] Patch to restore Import Window size and position Small patch to restore the last size and position of the import window
I created a new bug for remembering last Import Folder across sessions due to it is a bit more complicated to fix this one. See bug #357398 Therefore, the above patch should fix the original bug.
Bengt: I think your patch is not quite on target. The f-spot-import command (in tools/) calls core.Import which creates a new ImportCommand object whose class is defined in Core.cs, separate from the ImportCommand class defined in ImportCommand.cs (yay, great design!). So I think this bug is actually about positioning that window, not the dialog that's popped up when a user runs File -> Import from a normal F-Spot.
You sure? I just tested importing photos to f-spot, by importing it from the main window. I resized the import dialog and put it to one side. Then I run the f-spot --import <dir> command, and the import gui had the same size and location as when I last used it from the main window.
Ok, I was confused, it looks like your patch is correct for this bug, Bengt; sorry. Jeff: what do you mean by "arrangement"?
Hmm... It's been months since I wrote that :) I guess that by arrangement, I wanted to point out the vertical pane. You know, the separation between the thumbnails and the actual photo. It is important to remember the size of that, because it's also an annoying thing to resize (some people like small thumbnails, others want big ones, etc)
the proposed patch implements the request, but I'm not sure this should be the default behavior... or we'll receive plenty of bugs saying 'the import window appear in weird locations' or 'HIG recommends opening dialog on top of main window, esp. is the main window is frozen during that time'. Jeff, you know you can override default icon placing and sizing using window manager settings? and if your wm doesn't do that, look at devil's pie http://burtonini.com/blog/computers/devilspie
Well for the position thing, I agree it doesn't have to be remembered anymore, as it is the window manager's job. The size of the window and the vertical pane position, however, should be.
so we've a consensus... am ok with your latest proposition
fixed in r3266
many thanks for removing a painful needle from my foot! roar :)
this is not fixed in 0.4.0, is this normal? oh wait it works, but you need to actually import the photos. Does not work if you just open the import dialog, size it and "cancel". Could it work even if we do that? Better to have it work 100% of the time.
You don't really expect f-spot to save preferences while explicitely clicking on Cancel, do you ? Should be so weird... When I'm clicking on Cancel, I want to have everything restored as if nothing happened at all.
true, what you say does make sense. I guess I did not get enough sleep ;)