After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338295 - Arabic characters are not displayed correctly when printing tasks
Arabic characters are not displayed correctly when printing tasks
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Do Not Use
2.6.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Harish Krishnaswamy
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-04-13 03:33 UTC by Xiurong Simon Zheng
Modified: 2013-09-13 12:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
screenshot (348.43 KB, image/png)
2006-04-13 03:57 UTC, Xiurong Simon Zheng 		  Details
sun_patches (6.71 KB, patch)
2006-05-29 08:15 UTC, Cai Nan 		needs-work Details | Review
sun_patches (6.55 KB, patch)
2006-06-05 06:07 UTC, Cai Nan 		committed Details | Review

Description Xiurong Simon Zheng 2006-04-13 03:33:06 UTC 
Please describe the problem:
Currently, evolution doesn't use pango for text handling when printing tasks. So
printing e-cell-text doesn't support RTL language.

Steps to reproduce:
1. login in Arabic locale
2. invoke Evolution
3. create a task with arabic characters
4. print preview above task


Actual results:
Arabic text is RTL language but is showed in left-to-right order. 

Expected results:
Arabic text is printed in right-to-left order.

Does this happen every time?
Yes.

Other information:
Comment 1 Xiurong Simon Zheng 2006-04-13 03:57:41 UTC 
Created attachment 63355 [details]
screenshot
Comment 2 Cai Nan 2006-05-29 08:15:12 UTC 
Created attachment 66402 [details] [review]
sun_patches

I made several changes in e-cell-text.c, listed bellow:
1. Height of some special font is much higher than others,
   such as Arabic. So leave some more margin for cell: replace
   "16+4" by "16+8";
2. Replace "height" by "text_height" which is the actual height
   of the string to display when drawing text, under line, strike-
   through line.
3. For some right-to-left text, the horizontal position to draw
   under line or strikethrough line is extremely different from
   the left-to-right text. So I use PangoDirection to determine
   whether it is a right-to-left text or not.
Comment 3 Harish Krishnaswamy 2006-06-02 07:03:06 UTC 
Nancy, the g_assert introduced troubles me a bit - can this be tackled by raising an error instead ? We have been focusing on weeding out asserts for some time which are spread all over the code.

The patch otherwise looks fine. Thanks.
Comment 4 Cai Nan 2006-06-05 06:07:13 UTC 
Created attachment 66760 [details] [review]
sun_patches

replace g_assert by return.
Comment 5 Xiurong Simon Zheng 2006-06-05 06:13:51 UTC 
Harish, Nancy change a bit according to your suggestion. Please review again, thanks.
Comment 6 Xiurong Simon Zheng 2006-06-12 13:11:17 UTC 
Committed the patch to CVS HEAD and gnome-2-14 branch. Thanks.