After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338184 - [theoradec] don't leak element in _chain()
[theoradec] don't leak element in _chain()
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-12 08:36 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2006-04-13 09:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix element leak (673 bytes, patch)
2006-04-12 08:37 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		none Details | Review
fix the patch that fixes the leak (673 bytes, patch)
2006-04-12 08:39 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		none Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2006-04-12 08:36:10 UTC 
attached patch should fix element leakage. It would nice if someoen chould check if we leak the buffer too.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2006-04-12 08:37:00 UTC 
Created attachment 63287 [details] [review]
fix element leak
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2006-04-12 08:39:56 UTC 
Created attachment 63288 [details] [review]
fix the patch that fixes the leak
Comment 3 Tim-Philipp Müller 2006-04-12 08:48:50 UTC 
My copy of theoraenc.c has:

 static GstFlowReturn
 theora_enc_chain (GstPad * pad, GstBuffer * buffer)
 {
   ...
   enc = GST_THEORA_ENC (GST_PAD_PARENT (pad));
   ...
 }

GST_PAD_PARENT doesn't add a reference, so there's no need for a gst_object_unref(enc) either at the end, is there?
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2006-04-12 12:16:37 UTC 
ohh, shouldn't it do gst_pad_get_parent() ?
Comment 5 Tim-Philipp Müller 2006-04-13 09:26:59 UTC 
Don't think that's required in chain functions