After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338147 - gimp/desktop/Makefile.am::install-data-hook touches wrong directory
gimp/desktop/Makefile.am::install-data-hook touches wrong directory
Status: VERIFIED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-04-11 22:32 UTC by Henrik Brix Andersen
Modified: 2006-05-24 23:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (553 bytes, patch)
2006-04-11 22:33 UTC, Henrik Brix Andersen 		none Details | Review

Description Henrik Brix Andersen 2006-04-11 22:32:16 UTC 
Please describe the problem:
The install-data-hook in gimp/desktop/Makefile.am currently touches the hicolor
icon theme directory, but the way it is done will not work as intended for
installations with DESTDIR != /

This affects the Gentoo ebuilds for gimp as reported in the downstream bug
report at http://bugs.gentoo.org/129281


Steps to reproduce:
1. Install gimp CVS HEAD with DESTDIR=/foo



Actual results:
The install-data-hook will touch /usr/share/icons/hicolor

Expected results:
The install-data-hook should touch /foo/usr/share/icons/hicolor

Does this happen every time?
Yes

Other information:
Proposed patch coming up.
Comment 1 Henrik Brix Andersen 2006-04-11 22:33:13 UTC 
Created attachment 63269 [details] [review]
Proposed patch
Comment 2 Henrik Brix Andersen 2006-04-11 22:36:42 UTC 
Hmm - is the installer component only used for the Windows installer? That wasn't clear to me.
Comment 3 Manish Singh 2006-04-11 22:47:28 UTC 
2006-04-11  Manish Singh  <yosh@gimp.org>

        * desktop/Makefile.am: honor $(DESTDIR). Fixes bug #338147. Also
        some minor cleanups.