GNOME Bugzilla – Bug 338088
gnome-keyring-manager needs an interface to change keyring passwords
Last modified: 2009-08-17 17:27:14 UTC
Gnome-Keyring will hopefully soon have the ability to change a keyring's password. Gnome-keyring-manager should provide a menu item to support this.
Created attachment 63240 [details] [review] adds a Change keyring password menu item and dialog This patch works in conjunction with the final patch I have added to bug #151087. This allows a keyring's password to be changed from gnome-keyring-manager. As always, backup your ~/.gnome2/keyrings directory before testing.
Created attachment 63882 [details] [review] Missed some changes to Makefile.in This should apply and build cleanly to cvs. The necessary gnome-keyring patches have been applied to cvs as well.
Created attachment 67345 [details] [review] removed more cruft that crept into the last patch
what's happening with this patch? Is there a problem or is it just waiting to be reviewed. This is something we really need as more apps start to depend on keyring.
I think the gnome-keyring-manager is MIA or non-existant. I have been using the patch for a while and haven't had any problems. Would love to get it in, so I can start working on some other enhancements for gkm.
Fernando Herrera doesn't seem to be maintaining this anymore... any word from you, Fernando?
here I am. Sorry last months have been quite busy with my moving to Finland, but I hope to get my home DSL connection finally next week as well as proper cvs.gnome.org access at work soon. So I hope next week I could do some g-k-m work in order to set up a 2.16 beta release. OF course any help is pretty appreciated :)
I haven't tested the patch yet, but after a quick review, I don't think it could be applied before the next release cycle, because we are in UI freeze in this moment.
Can we get this merged so it can be tested? I would prefer it not wait through another release cycle.
I agree. Thanks for the remainder. At least I will take a look as soon as possible (less than one week I hope).
ping
Any hope to get these patch merged for gnome 2.18 ?
Please review this patch. Monday is the cut off for new features. Letting this push through another review cycle is a little irresponsible.
I just had a quick look at it, and found one small issue: GtkAction *action; + GtkAction *action1; action = gtk_action_group_get_action (self->priv->action_group, + "ChangepassKeyring"); + action1 = gtk_action_group_get_action (self->priv->action_group, "DeleteKeyring"); gtk_action_set_sensitive (action, sensitive); What's action1 added for? I don't see you using it.
Is anyone working on this?
We are now in UI freeze for 2.18. Cf. <http://live.gnome.org/TwoPointSeventeen>
Created attachment 82362 [details] [review] Rediff against svn head Rediff against svn head and fix small issue with sensitivity of the deletekeyring entry
The latest patch applies against v2.18 but it won't compile. Some Makefile badness.
did you regenerate the makefiles and the configure (autoreconf)? the patch is working for me
ping?
Is somebody looking into this?
I'll try to review this and get it in today. It's taken far too long already.
This would be great if the patch should be merged before the freeze period There is no way for the user to change his g-k password. This has some security issue
You can do change the password (as well as anything else gnome-keyring-manager does) using Seahorse now ;)
Should be merged quickly now that gdm has a buit-in fonction to unlock the keyring...
*** Bug 505362 has been marked as a duplicate of this bug. ***
gnome-keyring-manager has been deprecated and superseded by Seahorse more than one year ago. There has not been any active code development for more than a year. This bug will probably soon be closed as WONTFIX or OBSOLETE.
Thanks for taking the time to report this bug. However, gnome-keyring-manager won't be developed anymore and it has been superseded by Seahorse.
Seahorse also doesn't have the feature...
>> Seahorse also doesn't have the feature... Right-click keyring -> Change password
Thanks for pointing that out! For the sake of anyone else who is wondering: in the Passwords tab you can select a keyring (the lines that say "Passwords: <keyring name>" and from there you can mark a keyring as the default or change its password. Thanks again! :)