After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338088 - gnome-keyring-manager needs an interface to change keyring passwords
gnome-keyring-manager needs an interface to change keyring passwords
Status: RESOLVED OBSOLETE
Product: gnome-keyring-manager
Classification: Deprecated
Component: general
2.14.x
Other All
: Normal enhancement
: ---
Assigned To: Keyring manager maintainers
Keyring manager maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-11 14:40 UTC by Jon Nettleton
Modified: 2009-08-17 17:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
adds a Change keyring password menu item and dialog (28.14 KB, patch)
2006-04-11 14:44 UTC, Jon Nettleton
none Details | Review
Missed some changes to Makefile.in (97.15 KB, patch)
2006-04-19 16:28 UTC, Jon Nettleton
none Details | Review
removed more cruft that crept into the last patch (29.71 KB, patch)
2006-06-14 16:07 UTC, Jon Nettleton
none Details | Review
Rediff against svn head (26.98 KB, patch)
2007-02-12 03:26 UTC, Laurent Bigonville
none Details | Review

Description Jon Nettleton 2006-04-11 14:40:35 UTC
Gnome-Keyring will hopefully soon have the ability to change a keyring's
password.  Gnome-keyring-manager should provide a menu item to support this.
Comment 1 Jon Nettleton 2006-04-11 14:44:15 UTC
Created attachment 63240 [details] [review]
adds a Change keyring password menu item and dialog

This patch works in conjunction with the final patch I have added to bug #151087. This allows a keyring's password to be changed from gnome-keyring-manager.  As always, backup your ~/.gnome2/keyrings directory before testing.
Comment 2 Jon Nettleton 2006-04-19 16:28:39 UTC
Created attachment 63882 [details] [review]
Missed some changes to Makefile.in

This should apply and build cleanly to cvs.  The necessary gnome-keyring patches have been applied to cvs as well.
Comment 3 Jon Nettleton 2006-06-14 16:07:22 UTC
Created attachment 67345 [details] [review]
removed more cruft that crept into the last patch
Comment 4 Trevor Davenport 2006-07-29 20:16:22 UTC
what's happening with this patch?  Is there a problem or is it just waiting to be reviewed.  This is something we really need as more apps start to depend on keyring.
Comment 5 Jon Nettleton 2006-07-29 21:07:30 UTC
I think the gnome-keyring-manager is MIA or non-existant.  I have been using the patch for a while and haven't had any problems.  Would love to get it in, so I can start working on some other enhancements for gkm.  
Comment 6 Michael Monreal 2006-07-29 22:00:18 UTC
Fernando Herrera doesn't seem to be maintaining this anymore... any word from you, Fernando?
Comment 7 Fernando Herrera 2006-07-29 22:04:59 UTC
here I am. Sorry last months have been quite busy with my moving to Finland, but I hope to get my home DSL connection finally next week as well as proper cvs.gnome.org access at work soon.

So I hope next week I could do some g-k-m work in order to set up a 2.16 beta release. OF course any help is pretty appreciated :)
Comment 8 Germán Poo-Caamaño 2006-08-03 20:20:17 UTC
I haven't tested the patch yet, but after a quick review, I don't think it could be applied before the next release cycle, because we are in UI freeze in this moment.
Comment 9 Jon Nettleton 2006-11-10 17:05:00 UTC
Can we get this merged so it can be tested?  I would prefer it not wait through another release cycle.
Comment 10 Germán Poo-Caamaño 2006-11-10 18:11:01 UTC
I agree. Thanks for the remainder. At least I will take a look as soon as possible (less than one week I hope).
Comment 11 Jon Nettleton 2006-12-13 11:32:14 UTC
ping
Comment 12 Laurent Bigonville 2007-01-03 20:44:55 UTC
Any hope to get these patch merged for gnome 2.18 ?
Comment 13 Jon Nettleton 2007-01-06 02:04:56 UTC
Please review this patch.  Monday is the cut off for new features.  Letting this push through another review cycle is a little irresponsible.
Comment 14 Claudio Saavedra 2007-01-06 02:41:13 UTC
I just had a quick look at it, and found one small issue:

 	GtkAction *action;
+	GtkAction *action1;
 	action = gtk_action_group_get_action (self->priv->action_group,
+					      "ChangepassKeyring");
+	action1 = gtk_action_group_get_action (self->priv->action_group,
 					      "DeleteKeyring");
 	gtk_action_set_sensitive (action, sensitive);

What's action1 added for? I don't see you using it.
Comment 15 Guillermo Gutiérrez Herrera 2007-01-27 12:34:24 UTC
Is anyone working on this?
Comment 16 Mariano Suárez-Alvarez 2007-01-28 03:15:05 UTC
We are now in UI freeze for 2.18. Cf. <http://live.gnome.org/TwoPointSeventeen>
Comment 17 Laurent Bigonville 2007-02-12 03:26:18 UTC
Created attachment 82362 [details] [review]
Rediff against svn head

Rediff against svn head and fix small issue with sensitivity of the deletekeyring entry
Comment 18 dax 2007-03-16 07:07:14 UTC
The latest patch applies against v2.18 but it won't compile. Some Makefile badness.
Comment 19 Laurent Bigonville 2007-03-16 14:31:35 UTC
did you regenerate the makefiles and the configure (autoreconf)?
the patch is working for me
Comment 20 Laurent Bigonville 2007-04-27 09:06:41 UTC
ping?
Comment 21 Daniel Holbach 2007-05-24 13:19:58 UTC
Is somebody looking into this?
Comment 22 Guilherme de Siqueira Pastore 2007-06-10 12:27:40 UTC
I'll try to review this and get it in today. It's taken far too long already.
Comment 23 Laurent Bigonville 2007-07-04 14:19:08 UTC
This would be great if the patch should be merged before the freeze period

There is no way for the user to change his g-k password. This has some security issue
Comment 24 Michael Monreal 2007-07-04 16:21:22 UTC
You can do change the password (as well as anything else   	 gnome-keyring-manager does) using Seahorse now ;)
Comment 25 Laurent Bigonville 2007-07-28 15:26:45 UTC
Should be merged quickly now that gdm has a buit-in fonction to unlock the keyring...
Comment 26 Teppo Turtiainen 2007-12-28 21:47:42 UTC
*** Bug 505362 has been marked as a duplicate of this bug. ***
Comment 27 André Klapper 2008-11-15 18:14:07 UTC
gnome-keyring-manager has been deprecated and superseded by Seahorse more than one year ago.
There has not been any active code development for more than a year.

This bug will probably soon be closed as WONTFIX or OBSOLETE.
Comment 28 Germán Poo-Caamaño 2008-11-15 19:50:00 UTC
Thanks for taking the time to report this bug.
However, gnome-keyring-manager won't be developed anymore and it has
been superseded by Seahorse.
Comment 29 Sam Morris 2009-08-17 11:22:48 UTC
Seahorse also doesn't have the feature...
Comment 30 Michael Monreal 2009-08-17 13:27:53 UTC
>> Seahorse also doesn't have the feature...

Right-click keyring -> Change password
Comment 31 Sam Morris 2009-08-17 17:27:14 UTC
Thanks for pointing that out! For the sake of anyone else who is wondering: in the Passwords tab you can select a keyring (the lines that say "Passwords: <keyring name>" and from there you can mark a keyring as the default or change its password.

Thanks again! :)