After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338049 - support for 'registration color' during decomposition
support for 'registration color' during decomposition
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
2.2.x
Other All
: Normal enhancement
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-04-11 07:53 UTC by Clarence Risher
Modified: 2008-01-15 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to decompose.c with registration color support (7.47 KB, patch)
2006-04-11 07:56 UTC, Clarence Risher
needs-work Details | Review
patch to decompose.c with registration color support (6.60 KB, patch)
2006-04-11 14:43 UTC, Clarence Risher
committed Details | Review

Description Clarence Risher 2006-04-11 07:53:14 UTC
A registration color is a color that is represented by 100% values in all decomposed channels, regardless of the colors actual makeup.  It is used for things such as crop marks in images destined for physical media, which need to show up on all 4 (C M Y K) channels.  I think this would be a nice option to have in the decompose plugin.
Comment 1 Clarence Risher 2006-04-11 07:56:31 UTC
Created attachment 63225 [details] [review]
patch to decompose.c with registration color support

This patch adds support for a registration color, specified as the current foreground color.  It adds a new API call for scripts to toggle the registration on, a new checkbox in the decomposition dialog, and function to check pixels for the registration color and set them to 100% (255 specifically) in the destination layers, and a few extra globals to keep track of the option and foreground color.

There are inefficiencies, and excessive use of globals, both of which came about due to a change in my implementation partway through the task.  If any particular aspect is undesirable I will reimplement this otherwise.
Comment 2 Sven Neumann 2006-04-11 12:44:15 UTC
This patch doesn't apply against CVS HEAD. Please resubmit it after fixing the failing hunks.
Comment 3 Clarence Risher 2006-04-11 14:43:58 UTC
Created attachment 63239 [details] [review]
patch to decompose.c with registration color support

I was unknowingly working from the wrong CVS branch.  This patch is against cvs HEAD.  It is also quite a bit cleaner than the first one.
Comment 4 Sven Neumann 2006-05-29 13:11:50 UTC
Let's look at getting this patch into CVS for the 2.4 release.

The newly added checkbox probably needs a tooltip that explains what a Registration color is.
Comment 5 Sven Neumann 2006-06-06 08:40:16 UTC
I have changed this quite a bit, added const qualifiers and removed the extra argument for the newly added procedure.

2006-06-06  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/decompose.c: applied a modified patch from
	Clarence Risher that adds support for a registration color
	(bug #338049).