After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337814 - gestures blocking X with gtk+ 2.8.17
gestures blocking X with gtk+ 2.8.17
Status: RESOLVED FIXED
Product: epiphany-extensions
Classification: Deprecated
Component: gestures
2.14.x
Other Linux
: High critical
: 2.14.x
Assigned To: epiphany-extensions-maint
epiphany-extensions-maint
: 338016 338103 338185 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-04-09 16:05 UTC by Tommi Komulainen
Modified: 2006-04-12 09:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Tommi Komulainen 2006-04-09 16:05:55 UTC 
gtk+ 2.8.17 introduced some changes to grab-notify workings, as a result gestures are getting stuck; button releases, presses, key presses, nothing helps. The only way to use any application again is to switch to another console and kill epiphany.

What seems to happen is that grab_notify_cb() is called with was_grabbed=FALSE, something that didn't happen previously, and then the whole X is stuck.

Either adding 'if (was_grabbed)' in grab_notify_cb() or using priv->window when connecting to 'grab-notify' (like for all other signals) fixes this for me and seems to work also with older gtk versions. However I don't quite understand how everything is expected to play along here...
Comment 1 Christian Persch 2006-04-09 18:33:28 UTC 
Does the same thing happen in EphyNotebook (on 2.14), which also watches grab-notify ?
Comment 2 Tommi Komulainen 2006-04-09 18:57:55 UTC 
No, it works fine.
Comment 3 Christian Persch 2006-04-10 20:35:01 UTC 
mclasen: CC:ing you just so you're aware of this...

I'm fully prepared to be told it's just a bug in epiphany-extensions code; but it's a bit troubling that just upgrading gtk+ makes our code break completely...
Comment 4 Matthias Clasen 2006-04-10 21:01:33 UTC 
Ok, just to make sure I understand. You have problems because your
grab-notify handler does not pay attention to was_grabbed ? Or does
it get stuck even if you do pay attention to it ?

The changes in 2.8.17 make grab-notify behave as it was originally
intended. At some point in the 2.2/2.4 timeframe, a change was made which
causes us to emit grab-notify not often enough, which e.g. made us
vulnerable to assertions in the text view code.
Comment 5 Tommi Komulainen 2006-04-11 16:15:23 UTC 
It may be that ephy sets up / tears down the grab wrongly somehow and that's why it gets stuck. Prior to .17 grab-notify was not emitted, and now it is emitted with was_grabbed=FALSE -- so checking was_grabbed simply makes it behave as before.

I wonder whether the gestures code actually needs to do pointer and keyboard grabs? From what I quickly tried it seems that gtk_grab_add alone would suffice.
Comment 6 Lionel Dricot 2006-04-12 07:21:59 UTC 
*** Bug 338103 has been marked as a duplicate of this bug. ***
Comment 7 Lionel Dricot 2006-04-12 07:24:22 UTC 
Fix released with Ephy-Ext 2.14.1

* Fix gestures, auto-scroller and push-scroller extensionwith gtk+ 2.8.17 (#337814)

Feel free to reopen it you still have the issue.
Comment 8 Crispin Flowerday (not receiving bugmail) 2006-04-12 07:58:12 UTC 
*** Bug 338016 has been marked as a duplicate of this bug. ***
Comment 9 Sergej Kotliar 2006-04-12 09:25:15 UTC 
*** Bug 338185 has been marked as a duplicate of this bug. ***