After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337808 - [PATCH] Don't use empty volume label as mass storage DAP name
[PATCH] Don't use empty volume label as mass storage DAP name
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other All
: Normal minor
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-09 14:34 UTC by James Stembridge
Modified: 2006-06-03 19:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (822 bytes, patch)
2006-04-09 14:35 UTC, James Stembridge 		committed Details | Review

Description James Stembridge 2006-04-09 14:34:42 UTC 
Please describe the problem:
The mass storage dap plugin currently defaults to the volume label of the
device, even if the label is empty.

The attached patch fixes this by checking for an empty volume label.

Steps to reproduce:
1. Attach mass storage dap with no volume label.



Actual results:
Source with no name is displayed.

Expected results:


Does this happen every time?
Yes.

Other information:
Comment 1 James Stembridge 2006-04-09 14:35:28 UTC 
Created attachment 63027 [details] [review]
Patch
Comment 2 Patrick van Staveren 2006-05-30 17:57:34 UTC 
I have not tested, but it looks great.  Excellent catch!

Marking accepted-commit_now.
Comment 3 Aaron Bockover 2006-06-03 19:59:58 UTC 
Will be committed when I finish going through the rest of the patches. Thanks!