After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337807 - [PATCH] Mass storage dap filename escaping
[PATCH] Mass storage dap filename escaping
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other All
: Normal normal
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-09 14:19 UTC by James Stembridge
Modified: 2006-06-03 19:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (2.12 KB, patch)
2006-04-09 14:20 UTC, James Stembridge 		committed Details | Review

Description James Stembridge 2006-04-09 14:19:27 UTC 
Please describe the problem:
The mass storage dap plugin doesn't correctly escape the filenames of added tracks.

The attached patch adds escaping of the filename components.

Steps to reproduce:
Copy track with artist/album/title containing forward slash.



Actual results:
Extra directories will be incorrectly created.

Expected results:


Does this happen every time?
Yes.

Other information:
Comment 1 James Stembridge 2006-04-09 14:20:05 UTC 
Created attachment 63026 [details] [review]
Patch
Comment 2 Patrick van Staveren 2006-05-30 17:55:41 UTC 
I have not tested it myself, but this one looks good - recommend to apply to HEAD ASAP.

Marking accepted-commit_now.
Comment 3 Aaron Bockover 2006-06-03 19:56:59 UTC 
Will be committed when I finish going through the rest of the patches. Thanks!