After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337747 - don't use G_OBJECT_CLASS(klass) for each property
don't use G_OBJECT_CLASS(klass) for each property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal enhancement
: NONE
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-08 21:52 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2006-12-10 19:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for gst-plugins-base (15.86 KB, patch)
2006-06-21 17:19 UTC, Cody Russell 		committed Details | Review
gst-plugins-good patch (50.74 KB, patch)
2006-06-21 18:47 UTC, Cody Russell 		committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2006-04-08 21:52:56 UTC 
many plugins do
gobject_class = (GObjectClass*)klass;
and still later
g_object_class_install_property(G_OBJECT_CLASS(klass), ...);

They better use the macro first and tehn use the gobject_class var.
Comment 1 Wim Taymans 2006-04-21 18:20:39 UTC 
performance impact is very small. If someone does a batch update, this would be acceptable, marking as enhancement.
Comment 2 Cody Russell 2006-06-21 17:19:19 UTC 
Created attachment 67795 [details] [review]
Patch for gst-plugins-base

Here is a quick patch against cvs version of gst-plugins-base.
Comment 3 Cody Russell 2006-06-21 18:47:47 UTC 
Created attachment 67803 [details] [review]
gst-plugins-good patch

Here is another patch, this time for gst-plugins-good.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2006-09-17 11:52:13 UTC 
this is fixed in CVS for all modules.