After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337657 - stop playing playlist songs moved
stop playing playlist songs moved
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: playback
0.9.3
Other Linux
: Normal minor
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-07 16:43 UTC by Sebastien Bacher
Modified: 2006-06-25 02:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.54 KB, patch)
2006-06-23 14:26 UTC, James "Doc" Livingston 		none Details | Review

Description Sebastien Bacher 2006-04-07 16:43:20 UTC 
That issue has been described on https://launchpad.net/distros/ubuntu/+source/rhythmbox/+bug/38613

"If I play a file in a custom playlist, and re-organise the list by moving the file up/down, playing stops. That's a bug, I'd say."
Comment 1 James "Doc" Livingston 2006-04-09 09:45:46 UTC 
This is because rhythmdb_query_model_drag_data_received performs the move by removing the entry, and then re-adding it to the new location.

It probably needs to make the adjustment and emit a row-reordered signal. Doing it once per entry would probably be less efficient, but doing it once per drag could be complicated since entries may be added at the same time.
Comment 2 James "Doc" Livingston 2006-06-23 14:26:23 UTC 
Created attachment 67898 [details] [review]
patch

This does the above, and fixes the problem for me. I'm fairly certain it doesn't break anything, but given how easy it is to break stuff when touching the query-model dnd code it might,
Comment 3 Jonathan Matthew 2006-06-25 01:54:15 UTC 
Looks good to me.
Comment 4 James "Doc" Livingston 2006-06-25 02:18:29 UTC 
Okay, committed to cvs.