After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337655 - it should allow to use space characters as password
it should allow to use space characters as password
Status: RESOLVED FIXED
Product: gyrus
Classification: Other
Component: gyrus-admin
trunk
Other Linux
: Normal normal
: ---
Assigned To: Gyrus Maintainers
Gyrus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-07 16:34 UTC by Claudio Saavedra
Modified: 2007-03-17 01:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch from Andreas (688 bytes, patch)
2006-04-07 16:36 UTC, Claudio Saavedra
none Details | Review

Description Claudio Saavedra 2006-04-07 16:34:11 UTC
From  gyrus-list@gnome.org:

Hi!

While testing gyrus (which is really a nice utility)
I found a bug in function gyrus_admin_login() in file
gyrus-admin.c

The problem occurs if a user tries to login to the
IMAP server using a password which contains white
space characters like ASCII 0x20, which is perfectly
valid according to RFC1730 and RFC3501

Such a password has to be a literal string or quoted string,
though, and the quotes are missing in the gyrus sources as
of version 0.3.6

I'm attaching a patch which solves the problem by providing
double quote characters around the password (tested with
gyrus 0.3.6)

Please note: with the patch it is still not possible to
send passwords containing double quote characters. It
might be better to use literal strings as defined in
RFC1730, though this might make handling of the login
command a little bit complicated as the client has to
wait for the server command continuation request after
sending the initial {nnn}CRLF sequence.

Note also that the same is true for the userid field
of the login command.

HTH

- andreas

PS: I found gyrus' error message

Unable to connect with empty passwords.
Please introduce your password.

very misleading as the problem occured after entering a
valid password.
Comment 1 Claudio Saavedra 2006-04-07 16:36:28 UTC
Created attachment 62936 [details] [review]
Patch from Andreas
Comment 2 Claudio Saavedra 2007-03-17 01:07:25 UTC
Fixed in trunk (rev. 256):

2007-03-16  Claudio Saavedra  <csaavedra@alumnos.utalca.cl>

        * src/gyrus-admin.c: (gyrus_admin_listen_channel),
        (+imap_quote_string), (gyrus_admin_login): Quote password
        to allow password with special characters. Fixes bug #337655.