GNOME Bugzilla – Bug 337655
it should allow to use space characters as password
Last modified: 2007-03-17 01:09:45 UTC
From gyrus-list@gnome.org: Hi! While testing gyrus (which is really a nice utility) I found a bug in function gyrus_admin_login() in file gyrus-admin.c The problem occurs if a user tries to login to the IMAP server using a password which contains white space characters like ASCII 0x20, which is perfectly valid according to RFC1730 and RFC3501 Such a password has to be a literal string or quoted string, though, and the quotes are missing in the gyrus sources as of version 0.3.6 I'm attaching a patch which solves the problem by providing double quote characters around the password (tested with gyrus 0.3.6) Please note: with the patch it is still not possible to send passwords containing double quote characters. It might be better to use literal strings as defined in RFC1730, though this might make handling of the login command a little bit complicated as the client has to wait for the server command continuation request after sending the initial {nnn}CRLF sequence. Note also that the same is true for the userid field of the login command. HTH - andreas PS: I found gyrus' error message Unable to connect with empty passwords. Please introduce your password. very misleading as the problem occured after entering a valid password.
Created attachment 62936 [details] [review] Patch from Andreas
Fixed in trunk (rev. 256): 2007-03-16 Claudio Saavedra <csaavedra@alumnos.utalca.cl> * src/gyrus-admin.c: (gyrus_admin_listen_channel), (+imap_quote_string), (gyrus_admin_login): Quote password to allow password with special characters. Fixes bug #337655.