After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337578 - cpufreq-applet does not set the frequency for cpu being monitored
cpufreq-applet does not set the frequency for cpu being monitored
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: cpufreq
2.14.x
Other All
: Normal enhancement
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-07 03:05 UTC by Sandino Flores-Moreno
Modified: 2010-01-24 01:06 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Patch to set the speed of any monitored cpu. (2.08 KB, patch)
2006-04-08 03:14 UTC, Sandino Flores-Moreno 		committed Details | Review

Description Sandino Flores-Moreno 2006-04-07 03:05:30 UTC 
cpufreq has a preference to select the monitored cpu.

Clicking over the applet, a list of frequencies is displayed ir order to select
one of them.

However, the applet internally calls cpufreq-selector without specifying the
monitored cpu.

Then, the frequency is always applied to the default cpu (0 in the current
implementation).

This bug can be noticed in multicore cpus.
Comment 1 Sandino Flores-Moreno 2006-04-08 03:14:02 UTC 
Created attachment 62961 [details] [review]
Patch to set the speed of any monitored cpu.

Patch that implements the enhancement requested
Comment 2 Danielle Madeley 2006-04-08 03:19:24 UTC 
Was this committed? Why has it been marked as RESOLVED, FIXED?

This patch will break string freeze. It will not be able to go into the stable branch.
Comment 3 Sandino Flores-Moreno 2006-04-08 03:23:13 UTC 
Sorry, it was my fault.

I thought because I was the reporter I should mark it as FIXED.

Reverting.
Comment 4 Sandino Flores-Moreno 2006-04-08 03:28:31 UTC 
I'm an ignorant.

Why does it break string freeze?
Comment 5 Danielle Madeley 2006-04-08 04:26:07 UTC 
Actually, it doesn't. I wasn't paying attention.

This could go into 2.14.1 once reviewed.
Comment 6 Carlos Garcia Campos 2006-04-08 08:45:38 UTC 
Hi tigrux, thanks a lot for the report and the patch. I'm going to rewrite the popup-selector soon (after branch, of course), but for 2.14.x your patch could be a good solution. So, please check it in.
Comment 7 Sandino Flores-Moreno 2006-04-08 18:17:07 UTC 
Sorry.

What do you mean with check it in?

I don't think I can commit it.

Am I misunderstanding?
Comment 8 Carlos Garcia Campos 2006-04-08 18:47:20 UTC 
(In reply to comment #7)
> Sorry.
> 
> What do you mean with check it in?
> 
> I don't think I can commit it.

Sorry, I thought you could commit it. 

> Am I misunderstanding?
>
Comment 9 Carlos Garcia Campos 2006-04-08 18:47:56 UTC 
2006-04-08  Sandino Flores-Moreno  <tigrux@gmail.com>

        * src/cpufreq-popup.c: Call cpufreq-selector specifying the monitored
        cpu. Fixes bug #337578