After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337548 - Memory leaks in basertpdepayload
Memory leaks in basertpdepayload
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-06 20:57 UTC by Antoine Tremblay
Modified: 2006-04-11 17:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the memleaks (966 bytes, patch)
2006-04-06 20:59 UTC, Antoine Tremblay 		committed Details | Review

Description Antoine Tremblay 2006-04-06 20:57:36 UTC 
This patch will unref buffers that could still be in queue

and

also unref the input buffer in gst_base_rtp_depayload_push
even if there's no out_buf returned since some plugins like h263depay will copy and add the buffer to an adapter and returnnull as output buffer (in the process function) thus leaking the input buffer... this can be a major leak
Comment 1 Antoine Tremblay 2006-04-06 20:59:25 UTC 
Created attachment 62879 [details] [review]
Patch to fix the memleaks
Comment 2 Tim-Philipp Müller 2006-04-11 17:40:53 UTC 
thanks, committed with minor modifications:

 2006-04-11  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Antoine Tremblay  <hexa00 at gmail dot com>

        * gst-libs/gst/rtp/gstbasertpdepayload.c:
        (gst_base_rtp_depayload_finalize), (gst_base_rtp_depayload_push):
          Fix some memory leaks: on finalize, free buffers left in the queue
          before destroying the queue; in _push(), unref rtp_buf even if
          the process vfunc returned a NULL buffer as output buffer (#337548);
          demote some recuring debug messages to LOG level.