After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337421 - [sunaudiosink] some fixes
[sunaudiosink] some fixes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other opensolaris
: Normal normal
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-05 18:43 UTC by Brian Cameron
Modified: 2006-04-06 09:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix sunaudiosink (3.44 KB, patch)
2006-04-05 18:44 UTC, Brian Cameron 		committed Details | Review

Description Brian Cameron 2006-04-05 18:43:50 UTC 
Attached find a patch that fixes the sunaudiosink to use spec->segsize and spec->segtotal in the prepare function to initialize the ringbuffer instead
of using the buffer-time property.  This makes sunaudiosink work like the
recent fixes that wtay made to the esdsink.
Comment 1 Brian Cameron 2006-04-05 18:44:34 UTC 
Created attachment 62817 [details] [review]
patch to fix sunaudiosink
Comment 2 Tim-Philipp Müller 2006-04-06 09:16:41 UTC 
Committed, thanks!

 2006-04-06  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Brian Cameron  <brian dot cameron at sun dot com>

        * sys/sunaudio/gstsunaudiosink.c: (gst_sunaudiosink_init),
        (gst_sunaudiosink_prepare), (gst_sunaudiosink_write):
        * sys/sunaudio/gstsunaudiosink.h:
          Use spec->segsize and spec->segtotal in the prepare function
          to initialise the ring buffer instead of using the buffer-time
          property (#337421).