After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337386 - Pipeline bus is not initially flushing
Pipeline bus is not initially flushing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-05 14:59 UTC by Michael Smith
Modified: 2006-04-05 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Set pipeline bus to flushing on creation (721 bytes, patch)
2006-04-05 14:59 UTC, Michael Smith
none Details | Review

Description Michael Smith 2006-04-05 14:59:00 UTC
When a pipeline bus is created, it isn't initially flushing.
However, if we change the pipeline from NULL to READY then back to NULL, it will (by default) be flushing.

I'm fairly sure we should be setting this bus to flushing on creation (we already set it to non-flushing when we go to READY).

This causes leaks in tests/check/gst/gstghostpad.c (revealed when running under valgrind), as we add things to a pipeline when in NULL, receive a clock-provide message, and this message is never flushed (or read). 

The clock-provides message is itself bogus in this test (I'll file another bug for that), but if the added element was a real clock provider, this would be triggerable anyway.

I'll attach a patch that implements the behaviour I suggested, but I'm not sure how correct it is. Feedback appreciated. Note that this will cause any application listening for clock-provide messages on the bus with a pipeline in NULL to break. However, this is a pretty obscure case, and I don't know of any application that listens for clock-provide messages in any state.
Comment 1 Michael Smith 2006-04-05 14:59:46 UTC
Created attachment 62805 [details] [review]
Set pipeline bus to flushing on creation

Implement behaviour as described.
Comment 2 Michael Smith 2006-04-05 15:48:00 UTC
Patch committed with wim's approval.