After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337347 - Favorites tag is still a tag, not a category
Favorites tag is still a tag, not a category
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Tags
0.1.11
Other All
: Normal minor
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-05 11:30 UTC by Jean-Christophe Dubacq
Modified: 2006-06-06 22:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This trivial fix makes that when creating a db from scratch, favorites is a category, not a tag. (833 bytes, patch)
2006-04-05 16:43 UTC, Jean-Christophe Dubacq 		none Details | Review
better attachment (1.47 KB, patch)
2006-04-06 23:27 UTC, Jean-Christophe Dubacq 		committed Details | Review

Description Jean-Christophe Dubacq 2006-04-05 11:30:43 UTC 
Please describe the problem:
Favorites tag is still a tag, not a category. Tag are no more useful (except the
"hidden tag").

Steps to reproduce:
1. launch a f-spot with no previous db
2. look ma! No category for "favorites" !



Actual results:
One cannot add tags as subtags of "favorites".

Expected results:
One should be able to add tags, such as "really favorites", "cool pictures",
"for xscreensaver"...

Does this happen every time?
yes

Other information:
Patch:
line 386 of TagStore.cs should read
                Tag favorites_tag = CreateTag (RootCategory, Catalog.GetString
("Favorites"));
instead of
                Tag favorites_tag = CreateCategory (RootCategory,
Catalog.GetString ("Favorites"));

For completeness, the variable favorites_tag should be renamed to favorites_category
Comment 1 Jean-Christophe Dubacq 2006-04-05 16:43:05 UTC 
Created attachment 62808 [details] [review]
This trivial fix makes that when creating a db from scratch, favorites is a category, not a tag.

For sake of consistency
Comment 2 Jean-Christophe Dubacq 2006-04-06 23:27:52 UTC 
Created attachment 62886 [details] [review]
better attachment

This patch adds a database updater which acts also on old databases. Question remains whether the is_category should be dropped altogether.
Comment 3 Larry Ewing 2006-06-06 22:53:49 UTC 
committed