After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336945 - [filesink] throws error when writing 0 bytes
[filesink] throws error when writing 0 bytes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.4
Other Linux
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-02 17:42 UTC by Mark Nauwelaerts
Modified: 2006-04-04 15:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Possible patch. (551 bytes, patch)
2006-04-02 17:44 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2006-04-02 17:42:00 UTC 
GstFileSink uses fwrite to perform actual writes.
The return code is checked in a way that (always) "triggers" a GST_ELEMENT_ERROR if a buffer of 0 bytes was pushed to it.  Perhaps this is intentional, perhaps not ... ?
Comment 1 Mark Nauwelaerts 2006-04-02 17:44:05 UTC 
Created attachment 62616 [details] [review]
Possible patch.

Simple patch, only trigger error if there was at least really something to be written.
Comment 2 Tim-Philipp Müller 2006-04-04 15:46:05 UTC 
2006-04-04  Tim-Philipp Müller  <tim at centricular dot net>

       Patch by: Mark Nauwelaerts  <manauw at skynet dot be>

       * plugins/elements/gstfilesink.c: (gst_file_sink_render):
         Don't error out on empty buffers (#336945).