GNOME Bugzilla – Bug 336906
selection of multiple photos by mouse
Last modified: 2010-05-23 10:19:00 UTC
It would be nice if f-spot supported selection of multiple photos just like Picasa does - by drawing a rectangle with mouse Other information:
Related information in bug #341106
Still not possible... in 0.4.1
*** Bug 554803 has been marked as a duplicate of this bug. ***
Created attachment 119893 [details] [review] Please check if the following patch correct this bug
thanks Vincent. few things i noticed 1. you can start selecting only out of a thumb area, that's a bit less intuitive to me, mainly because that area is very tight. but maybe i'm wrong, 'cause no way comes to my mind to understand if it's a photo drag or a selection start. oh, i see you introduced that area :) 2. the selection area is BEHIND the photos, and with selection active over them is really hardly visible. it should be above the thumbs, and with some sort of transparency 3. while dragging and trying to scroll iconview, this motion is very slow (the selection itself is quite slow, imo). 4. the patch causes some problems when dates below thumbs are visible: the date is partially displayed over the image. didn't check with filenames enabled too. 5. when submitting patch always generate diff from f-spot root, not from src/ ciao, thanks
Created attachment 119923 [details] [review] new patch for rectangular selection Hi Maxxer and thanks for your comments ! I've attached a new patch with faster scroll, xor selection (I don't know how to manage with transparency in C#, is it possible ?) and correction with the date display. I've no idea about a different way to decide between drag&drop and selection. Note that clicking on the details (date, tags...) start a selection, not a drag&drop.
Created attachment 119934 [details] [review] this one has nicer selection rectangle
excellent. * i don't know if it's the slowness of my pc or what, but when i release the mouse button f-spot still holds the selection for the following ~second. it's probably related to infobox update timeout, check for that. * when the selection is done and you click on one of the selected pictures, f-spot doesn't highlight that only picture any more. the selection changes, but the highlight is still active on all pictures * i would still prefer to see the selection rectangle above the pictures, but i'm sorry i can't help you on transparency * i don't know if it's possible, but when it's not a drag start it would be great if a single click on date/filename would still select the picture, like used before the patch. but maybe it's an unnecessary request, i should ask... thanks!
Created attachment 120048 [details] [review] Should correct your points This new patch should correct the selection rectangle. When you click on an already selected pictures, the original code was not clearing the full selection. I've changed that. Now, button press start rectangular selection or drag&drop, if none, button release do cell selection. This should give a better feeling.
I tested the patch and I like the way it behave. I still have to review the patch though.
Created attachment 136308 [details] [review] Selection with alpha channel This new patch introduces transparent color (alpha channel) using Cairo. It also fix a bug causing crashes.
Vincent: cool, I'm poking a few people that are working on IconView to get this moving :-)
it works, kinda. need some work. - the selection is somewhat off, I mean the rectangle does not starts drawing from the point I clicked first. - sometimes, when clicking outside of the selection to start a new one, it takes the pictures so I can drag them away, like if I started my drag from inside the selection - invert selection takes 30 secs here. I know you're not to blame for this, but it can't be offered as is (fixing this is still on my whiteboard since I first reviewed this patch months ago) -
Lamalex (Alex Launi) is also looking into this by the way.
In ~vpomey/f-spot/vpomeys-clone:bgo336906 you will find expected fix to your first two points. Please check. As for invert selection, with about 1000 pictures it is quite fast. What kind of fix do you want to do ?
This is cool stuff! I've updated your patch and pushed it in a branch here: http://git.gnome.org/browse/f-spot/log/?h=iconview-selection Seems to work reasonably well. The only issue I'm having is that sometimes it doesn't seem to notice a release event. I release my mouse button but it still thinks that the button is pressed. Let's try to get that fixed, I want this merged in master. Note that it could by my fault too, I poked quite a bit to get it applied.
I've tried to reproduce this bug. I've found a problem with button release events being delayed of several seconds after playing a lot with the mouse. This is fixed by adding EventMask.PointerMotionHintMask to the AddEvents call, line 235 of git.gnome.org IconView.cs. Does it fix your problem ?
Yes, that exactly fixes the pointer release bug, much better! I pushed a new and rebased iconview-metadata branch with this fix. Let's give this some more testing and see if we can get it into master.
I've merged this into master, it's a killer feature and I'm really glad to have it in. This is going to get a prominent place in the next release notes. Thanks Vincent!