After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336889 - [avidemux] index creation might fail with some non-indexed AVI files
[avidemux] index creation might fail with some non-indexed AVI files
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-02 00:58 UTC by Fabrizio Gennari
Modified: 2006-04-20 16:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch fixing index creation (4.98 KB, patch)
2006-04-02 00:58 UTC, Fabrizio Gennari 		committed Details | Review

Description Fabrizio Gennari 2006-04-02 00:58:13 UTC 
Please describe the problem:
If an AVI file does not have an index, it is created. The functions which create
it, however, make the wrong assumption that data can only contain LIST and movi
fourcc's. If an AVI file contains a LIST with a 'rec ' fourcc, garbage is read.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Fabrizio Gennari 2006-04-02 00:58:50 UTC 
Created attachment 62575 [details] [review]
Patch fixing index creation
Comment 2 Tim-Philipp Müller 2006-04-20 16:38:23 UTC 
Thanks, committed:

 2006-04-20  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Fabrizio Gennari  <fabrizio dot ge at tiscali dot it>

        * gst/avi/gstavidemux.c: (gst_avi_demux_peek_tag),
        (gst_avi_demux_next_data_buffer), (gst_avi_demux_stream_scan):
          Fix index creation when we have to scan the file to create
          an index. There may be other types of RIFF 'LIST' chunks than
          'movi' and we need to skip them properly as well or we'll end up
          reading garbage (#336889). Some other cosmetic changes.

Sorry it took so long until someone got around to reviewing the patch.