After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336881 - [libvisual] additional support for libvisual-0.4
[libvisual] additional support for libvisual-0.4
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 336882 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-04-01 22:31 UTC by Florian Steinel
Modified: 2006-05-21 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libvisual-fix.patch (387 bytes, patch)
2006-04-01 22:37 UTC, Florian Steinel
none Details | Review
first attempt at a patch (3.99 KB, patch)
2006-04-06 18:10 UTC, Tim-Philipp Müller
committed Details | Review
gst-base-plugin-libvisual in totem -> "libvisual libvisual corona plugin plugin" (63.79 KB, image/png)
2006-05-21 17:04 UTC, Florian Steinel
  Details

Description Florian Steinel 2006-04-01 22:31:51 UTC
witkaout the patch gstreamer complains about the missing visual_list_count symbol in libvisual (wich was replaced by visual_collection_size):

2005-09-05  Dennis Smit  <ds@nerds-incorporated.org>

	* libvisual/lv_cache.c: Use visual_collection_size instead of obsolete
	visual_list_count.
Comment 1 Florian Steinel 2006-04-01 22:37:20 UTC
Created attachment 62569 [details] [review]
libvisual-fix.patch

replace the function visual_list_count with visual_collection_size in ext/libvisual/visual.c
Comment 2 Florian Steinel 2006-04-01 22:40:11 UTC
This also applies to CVS-HEAD 
Comment 3 Tim-Philipp Müller 2006-04-06 17:42:19 UTC
I don't think this is going to be changed in the 0.8 branch, but we're of course more than happy to fix this in HEAD.

However, I played around a bit with it today and it looks like there's a bit more needed than just this one-line change (patch attached, see FIXME in the _is_gl() function).

Comment 4 Tim-Philipp Müller 2006-04-06 18:07:31 UTC
*** Bug 336882 has been marked as a duplicate of this bug. ***
Comment 5 Tim-Philipp Müller 2006-04-06 18:10:06 UTC
Created attachment 62869 [details] [review]
first attempt at a patch

Patch that maintains backwards compatibility with 0.2.
Comment 7 Tim-Philipp Müller 2006-05-15 10:21:18 UTC
Seems to work well enough for me, I'm sure people will post patches if they find the filter doesn't work right or is too strict.

 2006-05-15  Tim-Philipp Müller  <tim at centricular dot net>

        * configure.ac:
        * ext/libvisual/visual.c: (gst_visual_actor_plugin_is_gl),
        (plugin_init):
          Add tentative support for libvisual-0.4 (#336881).
Comment 8 Florian Steinel 2006-05-21 17:04:13 UTC
Created attachment 65954 [details]
gst-base-plugin-libvisual in totem -> "libvisual libvisual corona plugin plugin"

double display of "libvisual" and "plugin" in discription.
Comment 9 Florian Steinel 2006-05-21 17:08:40 UTC
is this an bug in gst-plugin-base-libvisual or in Totem?