GNOME Bugzilla – Bug 336822
f-spot screensaver should have an 'all pictures' option
Last modified: 2007-06-09 19:26:14 UTC
Please describe the problem: Currently I show *all* my pictures in xscreensaver, and very many of them aren't tagged yet in f-spot. It would be really nice if I could just select 'show all pictures' in my f-spot screensaver options. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Changing this to an Enhancement Request
Created attachment 72443 [details] [review] First attempt at supporting 'All' photos I also don't like being forced to choose a category, since I don't have a set of photos tagged as favorites - I want to see everything. So, here's a rough patch that achieves that, by defaulting to showing all photos if the GConf key doesn't correspond to a tag. Maybe not the *right* way, but it works as a starting point. I've not made any UI changes (I can't follow that code so well), so the only way to activate it is by using gconf-editor to change the tagid to something invalid (such as 0 or -1).
confirming and noting that this is still in 0.2.1 :(
Good try Simon, I think this is a bit better: Photo [] photos; if (tag != null) photos = db.Photos.Query (new Tag [] { tag } ); + else if ((int) Preferences.Get (Preferences.SCREENSAVER_TAG) == 0) + photos = db.Photos.Query (new Tag [] {}); else photos = new Photo [0]; this way, the screensaver will only show all pictures if the tag_id is 0. Otherwise, selecting a tag for the screensaver, then removing it will start displaying all your collection as screensaver. I'm currently checking what are the possibilities in the UI...
Created attachment 82602 [details] [review] complete patch with UI this patch adds the UI part. Since the screensaver is not working for me, PLEASE TEST THIS AND REPORT (it should be ok and working, but...)
Created attachment 82603 [details] mandatory screenshot
I might suggest it just be the first entry in the tags dropdown- something like 'all tags' or 'all pictures'- instead of a radio selection. Seems like it should be easy enough to find there, without cluttering the dialog.
Hi Luis, I thought about that also, but for some widget reusabilty reason it's not possible...
Ah, well, not a huge deal. Hope it makes it into an f-spot release before Feisty freezes :)
And thanks!
Hi Luis, Feisty froze one week ago :( Am just waiting for one positive test to push that in svn
(In reply to comment #11) > Hi Luis, > > Feisty froze one week ago :( > > Am just waiting for one positive test to push that in svn >
Hmm... Must be doing something wrong here... Applied the patch, and fixed Core.cs so it would patch/compile Index: src/Core.cs =================================================================== --- src/Core.cs (revision 3138) +++ src/Core.cs (working copy) @@ -154,6 +154,8 @@ Photo [] photos; if (tag != null) photos = Database.Photos.Query (new Tag [] { tag } ); + else if ((int) Preferences.Get (Preferences.SCREENSAVER_TAG) == 0) + photos = Database.Photos.Query ((Tag []) null ); else photos = new Photo [0]; But when I select All Images, I get 0 photos. Selecting any other tag works fine. footnote: I am not installing f-spot in the default location, so I modify the f-spot-screensaver file to point to ~/unstable/f-spot/bin/f-spot. My screensaver f-spot do not work when it is applied from within F-Spot, but when I let Gnome set it (Changing from Blank, to F-Spot Photos for instance), the F-Spot screensaver starts. Easiest to verify is to use the preview function in Gnome screensaver settings. :)
(In reply to comment #13) > I am not installing f-spot in the default location, so I modify the > f-spot-screensaver file to point to ~/unstable/f-spot/bin/f-spot. Where is the file you modified? I couldn't find it :( I just get a black screen
Index: tools/f-spot-screensaver =================================================================== --- tools/f-spot-screensaver (revision 3138) +++ tools/f-spot-screensaver (working copy) @@ -1,2 +1,3 @@ #!/bin/sh -exec f-spot --slideshow +#exec f-spot --slideshow +exec /home/bengt/unstable/f-spot/bin/f-spot --slideshow
guessed so :) I also forgot to add the --basedir and --photodir in the file. btw using the button in preferences I get only a black screen, any tag choosen. if I manually run libexec/gnome-screensaver/f-spot-screensaver the screensaver starts, and all the pictures are shown correctly.
Created attachment 89657 [details] [review] updated patch works fine now. committed in r3143