Bug 336756 – move ximagesrc to gst-plugins-good

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 336756 - move ximagesrc to gst-plugins-good


Summary:	move ximagesrc to gst-plugins-good


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-plugins-good
Version:	git master
Hardware:	Other Linux

Importance:	Normal major
Target Milestone:	0.10.3
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2006-03-31 17:59 UTC by Zaheer Abbas Merali
Modified:	2006-04-30 14:36 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
patch to gst-plugins-good configure.ac and sys/Makefile.am (3.47 KB, patch) 2006-04-07 16:19 UTC, Zaheer Abbas Merali	committed	Details \| Review
patch to configure.ac and sys/Makefile.am to remove ximagesrc from bad (5.09 KB, patch) 2006-04-07 16:23 UTC, Zaheer Abbas Merali	committed	Details \| Review

Description Zaheer Abbas Merali 2006-03-31 17:59:13 UTC

I would like to move ximagesrc from -bad to -good.

Going through the checklist:

 * I am willing to actively maintain the element

 * plugin's code:
    - base class: GstPushSrc
    - uses boilerplate macros
    - conforms to GStreamer coding style
    - has a custom debug category
    - uses GST_*_OBJECT where possible

 * compiled plugin
    - shows up properly in gst-inspect

 * is in the correct location (/sys)

 * documented:
    - correct element description and plugin description
    - has a gtk-doc blurb with pipeline example

 * unit tests:
    - in -bad tests/icles/ximagesrc-test.c
    - test is leak-free with valgrind

 * license:
    - plugin code is LGPL
    - X libs are X11 licence

Comment 1 Michael Smith 2006-04-07 15:55:05 UTC

I've done a code review, and I'm willing to be the 'sponsor' for this. I made a number of small suggestions to Zaheer; he has fixed those things. I've also tested it with the suggested pipeline - it works correctly.

I believe it's ready to be moved.

Zaheer; can you attach two patches to this bug that have all the appropriate changes for configure.ac, sys/Makefile.am, etc. in both bad and good, so that then actually moving the plugin just requires applying those and doing the cvs surgery to move the actual ximagesrc directory?

Comment 2 Zaheer Abbas Merali 2006-04-07 16:19:02 UTC

Created attachment 62933 [details] [review]
patch to gst-plugins-good configure.ac and sys/Makefile.am

Comment 3 Zaheer Abbas Merali 2006-04-07 16:23:54 UTC

Created attachment 62934 [details] [review]
patch to configure.ac and sys/Makefile.am to remove ximagesrc from bad

Comment 4 Tim-Philipp Müller 2006-04-30 14:36:59 UTC

Closing, as it's been moved now:

2006-04-28  Thomas Vander Stichele  <thomas at apestaart dot org>

        * configure.ac:
        * tests/Makefile.am:
          add ximagesrc icles test

2006-04-28  Thomas Vander Stichele  <thomas at apestaart dot org>

        * configure.ac:
        * docs/plugins/Makefile.am:
        * docs/plugins/gst-plugins-good-plugins-docs.sgml:
        * docs/plugins/gst-plugins-good-plugins-sections.txt:
        * ext/annodex/gstcmmlenc.c: (gst_cmml_enc_class_init),
        (gst_cmml_enc_push_clip):
        * sys/Makefile.am:
        * sys/ximage/Makefile.am:
        * sys/ximage/gstximagesrc.c:
          Move ximagesrc plug-in to good after review.  Fixes #336756.