After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336713 - Can't operate addressbook after double pasting more than 20 contacts
Can't operate addressbook after double pasting more than 20 contacts
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
2.6.x (obsolete)
Other All
: Normal critical
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-03-31 09:38 UTC by Xiurong Simon Zheng
Modified: 2006-04-21 10:11 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
A sample vard containing more than 20 contacts. (12.54 KB, application/octet-stream)
2006-03-31 09:42 UTC, Xiurong Simon Zheng 		  Details
Patch (1.53 KB, patch)
2006-03-31 09:59 UTC, Xiurong Simon Zheng 		accepted-commit_now Details | Review

Description Xiurong Simon Zheng 2006-03-31 09:38:38 UTC 
Please describe the problem:
Doulble paste more than 20 contacts and *cancel* duplicate at the second paste,
then we can't add any contacts again.

Steps to reproduce:
1. launch evolution
2. import 25 contacts to a specified addressbook.
3. cut above 25 contacts.
4. paste contacts in current addressbook.
5. repeat step 4, paste again. And click "Cancel" buttons in all duplicate
confirm dialogs,
6. can't add or paste any contacts again.


Actual results:
Can't add or paste any contacts after double paste more than 20 contacts.

Expected results:
Still work fine after double paste.

Does this happen every time?


Other information:
Comment 1 Xiurong Simon Zheng 2006-03-31 09:42:01 UTC 
Created attachment 62444 [details]
A sample vard containing more than 20 contacts.

Use to reproduce.
Comment 2 Xiurong Simon Zheng 2006-03-31 09:59:25 UTC 
Created attachment 62447 [details] [review]
Patch

When we prepare to add a contact, one EContactMergingLookup will add to merging queue. However, if selecting "cancel duplicate" in confirmation dialog when doulbe pasting, those EContactMergingLookup can't be removed. 

So after the merging queue is full, saying 20 requests. No contacts can be added again for any addressbook.

Solution is making finished_lookup() is always invoked.
Comment 3 Devashish Sharma 2006-04-21 08:05:13 UTC 
Patch looks good to me.
Fix Committed to cvs head.
Comment 4 Xiurong Simon Zheng 2006-04-21 08:53:15 UTC 
Devashish, thanks for your review. Can we check this patch in gnome-2-14 bransh too?
Comment 5 Xiurong Simon Zheng 2006-04-21 10:11:02 UTC 
Also committed to gnome-2-14 bransh. Thanks.