After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336652 - eog overwrites GErrors
eog overwrites GErrors
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-30 17:54 UTC by Matthias Clasen
Modified: 2006-03-31 23:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Matthias Clasen 2006-03-30 17:54:42 UTC
eog_thumb_data_new 

        if (result != GNOME_VFS_OK) {
                set_vfs_error (error, result);
        }

        /* check required info fields */
        if (((info->valid_fields & GNOME_VFS_FILE_INFO_FIELDS_MTIME) == 0) ||
            ((info->valid_fields & GNOME_VFS_FILE_INFO_FIELDS_MIME_TYPE) == 0))
        {
                set_thumb_error (error, EOG_THUMB_ERROR_GENERIC, "MTime or mime type not available");
        }

is missing an else before the second if. No need to set the error twice.
Comment 1 Lucas Rocha 2006-03-31 23:42:51 UTC
Fixed in HEAD and stable branches. Thanks!

2006-03-31  Lucas Rocha  <lucasr@gnome.org>

        * libeog/eog-thumbnail.c (eog_thumb_data_new): avoid setting
        the error twice (Fixes bug #336652).