After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336644 - GailButton release action should synthesize a GdkEvent
GailButton release action should synthesize a GdkEvent
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: gail
git master
Other All
: Normal enhancement
: ---
Assigned To: bill.haneman
bill.haneman
Depends on:
Blocks:
 
 
Reported: 2006-03-30 17:05 UTC by Jose Dapena Paz
Modified: 2006-11-07 18:19 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
GdkEvent implementation of GailButton "release" action (657 bytes, patch)
2006-03-31 10:04 UTC, Jose Dapena Paz 		committed Details | Review

Description Jose Dapena Paz 2006-03-30 17:05:32 UTC 
Now GailButton implements "press" and "release" actions in a different way. For
"press" event, it synthesizes a GdkEvent. But the release action simply calls
gtk_button_release to do the same work. It prevents buttons with handlers
listening to button_release_event" from getting "release" actions.

It would be preferrable that the "release" action would be implemented in the
same way "press" action is implemented.
Comment 1 Jose Dapena Paz 2006-03-31 10:04:40 UTC 
Created attachment 62448 [details] [review]
GdkEvent implementation of GailButton "release" action

This is an implementation of the "release" action of GailButton synthesizing a GdkEvent. It's quite similar to the solution used for the "press" action. I've tested it with some test cases I have here, and it works the same way the original code did, but solving my problem with button-press-event and button-release-event handling (now the action fires these events as expected).
Comment 2 bill.haneman 2006-11-07 17:35:57 UTC 
Comment on attachment 62448 [details] [review]
GdkEvent implementation of GailButton "release" action

patch looks good, thanks for the work!

in future, diff -u would be a preferable format for patches.
Comment 3 bill.haneman 2006-11-07 17:38:37 UTC 
Please commit if you are able, otherwise ask me and I will commit the patch.
Comment 4 Jose Dapena Paz 2006-11-07 17:52:07 UTC 
I haven't got a cvs account. So yes, please commit it.

Thanks!