After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336605 - Cannot compile metacity with --disable-xsync specified
Cannot compile metacity with --disable-xsync specified
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.14.x
Other All
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2006-03-30 12:16 UTC by Andy Morum
Modified: 2006-04-15 22:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Move grab_last_user_action_was_snap to fix compile (685 bytes, patch)
2006-04-11 18:18 UTC, Andy Morum 		committed Details | Review

Description Andy Morum 2006-03-30 12:16:51 UTC 
Please describe the problem:
I tried to compile Metacity 2.14.1 with the --disable-xsync flag set, but 
unfortunately the compile fails with the following error:

edge-resistance.c: In function ‘meta_window_edge_resistance_for_move’:
edge-resistance.c:1116: error: ‘struct _MetaDisplay’ has no member 
named ‘grab_last_user_action_was_snap’
edge-resistance.c: In function ‘meta_window_edge_resistance_for_resize’:
edge-resistance.c:1205: error: ‘struct _MetaDisplay’ has no member 
named ‘grab_last_user_action_was_snap’
make[4]: *** [edge-resistance.o] Error 1
make[4]: Leaving directory `/home/retro/newmet/metacity-2.14.1/src'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/retro/newmet/metacity-2.14.1/src'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/retro/newmet/metacity-2.14.1/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/retro/newmet/metacity-2.14.1'
make: *** [all] Error 2



Steps to reproduce:
1. ./configure --disable-xsync 
2. make


Actual results:
compile fails

Expected results:


Does this happen every time?
yes

Other information:
I am building this on Ubuntu Dapper, and the build completes as expected 
without this flag set. The Metacity sources are from the Gnome servers, not the 
Ubuntu patched version.
Comment 1 Elijah Newren 2006-03-30 16:22:38 UTC 
This should be a relatively easy fix for someone looking to get involved in Gnome -- it just looks like I didn't pay attention to where all the #ifdef's were when I added the variable to display.h.  It probably just needs to be moved.  There may be a couple other vars that need to be moved to get it to compile, but it'll probably be the same kind of thing.
Comment 2 Andy Morum 2006-04-11 18:18:40 UTC 
Created attachment 63252 [details] [review]
Move grab_last_user_action_was_snap to fix compile

No idea if this variable is in the correct place for readability, but it does at least fix the compile. :)

Andy.
Comment 3 Elijah Newren 2006-04-11 19:47:56 UTC 
Looks good, thanks.  Do you have a CVS account?  If not, can you post a ChangeLog entry in a comment here and I'll commit it for you?