After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336380 - red eye removal often 'fixes' more than just eyes
red eye removal often 'fixes' more than just eyes
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Editing
0.1.10
Other All
: Normal minor
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-28 17:54 UTC by michal
Modified: 2007-02-13 13:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
stand-alone example program showing improved redeye removal (4.12 KB, application/x-compressed-tar)
2006-03-28 17:56 UTC, michal
Details

Description michal 2006-03-28 17:54:26 UTC
The red eye removal tool in f-spot does a pretty good job of fixing the redeye
in a selected region, but it is often overzealous, and 'corrects' more than just
the eye.  With a rectangular region, its hard to get just the part of the eye
that is wanted.

Perhaps a better model for red-eye correction would be to enter 'red-eye
correction mode' in which a click on the photo fixes a connected red region.

I've thrown together a quick gtk program that does simply this:  you start it up
with a file name as an argument, then every click in a red region corrects that
region.  So if there are 6 red eyes, you just click on each eye.  In this
program, closing the window gives a prompt for a file name to save to. 
Something like this I think would make the red eye tool much more useful.  I'll
attach my program as an attachment.

Other information:
Comment 1 michal 2006-03-28 17:56:18 UTC
Created attachment 62230 [details]
stand-alone example program showing improved redeye removal
Comment 2 Bengt Thuree 2006-05-17 09:25:02 UTC
Would it be possible to create a small patch for F-Spot to do this?
A patch would be quicker to accept than an request for an enhancement...
Comment 3 Pascal de Bruijn 2006-11-15 19:29:19 UTC
I think this bug is related to:
http://bugzilla.gnome.org/show_bug.cgi?id=356438
Comment 4 Pascal de Bruijn 2006-11-15 19:31:20 UTC
I can confirm this bug. If a face is somewhat red-ish, often the brows of the person will be mangled as well. And the rectacle shape of the selection doesn't help with that.

I personally like the magic-wand idea suggested here.
Comment 5 Stephane Delcroix 2007-02-13 13:57:48 UTC
I pushed a new improved red-eye reduction code in svn on last xmas.