After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336290 - evolution-webcal should use goption instead of popt
evolution-webcal should use goption instead of popt
Status: RESOLVED FIXED
Product: Evolution Webcal
Classification: Deprecated
Component: General
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Rodney Dawes
Rodney Dawes
Depends on:
Blocks:
 
 
Reported: 2006-03-28 06:15 UTC by Michael Plump
Modified: 2006-12-19 22:04 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
replaces popt with goption (1.98 KB, patch)
2006-03-28 06:16 UTC, Michael Plump
none Details | Review
Fix a build warning. (1.95 KB, patch)
2006-08-09 04:59 UTC, Lucas Rocha
none Details | Review

Description Michael Plump 2006-03-28 06:15:42 UTC
Attached (in a second) is a patch that replaces evolution-webcal's use of popt
with goption.
Comment 1 Michael Plump 2006-03-28 06:16:09 UTC
Created attachment 62178 [details] [review]
replaces popt with goption
Comment 2 André Klapper 2006-04-20 20:55:51 UTC
harish, can we please get this further popt->goption patch in, so that this gnome goal is resolved for the evolution family? or at least somebody reviewing it so i can commit? thanks in advance...

http://live.gnome.org/GnomeGoals/PoptGOption
Comment 3 Rodney Dawes 2006-04-21 00:18:32 UTC
Harish does not maintain evolution-webcal, I do. I'll look at it soon. I still need to branch evolution-webcal though.
Comment 4 André Klapper 2006-04-21 10:25:57 UTC
uhm, sorry dobey, didnt know. np :-)

(removing harish from cc, you already get too much mail)
Comment 5 Lucas Rocha 2006-08-09 04:59:53 UTC
Created attachment 70523 [details] [review]
Fix a build warning.

Rodney, this patch from is OK to commit. We'll need to wait for the next development cycle because it adds one string for translation and we're string frozen now.
Comment 6 Lucas Rocha 2006-08-09 05:12:56 UTC
Remember to add dependency check on libgnome >= 2.14.0 and latest glib to make sure everything works fine.
Comment 7 André Klapper 2006-11-29 15:24:29 UTC
hi dobey,
can we please get this in for 2.17 by branching evo-webcal, just to get this gnome goal done?
thanks in advance.
Comment 8 Rodney Dawes 2006-12-04 16:57:02 UTC
Hrmm. The patch uses both URI and URL. I would prefer if it just used URI. I also don't see any reason to translate the string "[URI...]". Do any languages actually translate URI or URL?
Comment 9 Lucas Rocha 2006-12-05 21:27:30 UTC
Agreed, you're right. I don't think we need mark "URI..." for translation.
Comment 10 Rodney Dawes 2006-12-19 22:04:30 UTC
Committed to CVS with said changes.