After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336194 - [gnomevfssrc] some minor memory leaks
[gnomevfssrc] some minor memory leaks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.5
Other All
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-27 14:03 UTC by Tommi Myöhänen
Modified: 2006-03-27 16:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for freeing up the tag strings. (798 bytes, patch)
2006-03-27 14:06 UTC, Tommi Myöhänen 		committed Details | Review

Description Tommi Myöhänen 2006-03-27 14:03:46 UTC 
Please describe the problem:
Gnomevfssrc has a few minor mem leaks. In _finalize(), the iradio tags are not 
freed. Also, after parsing icecast metadata, the allocated block containing tag 
string is not freed.



Steps to reproduce:



Actual results:



Expected results:



Does this happen every time?



Other information:
Comment 1 Tommi Myöhänen 2006-03-27 14:06:25 UTC 
Created attachment 62125 [details] [review]
Patch for freeing up the tag strings.

Attached is patch that should resolve the problem.
Comment 2 Tim-Philipp Müller 2006-03-27 16:38:13 UTC 
Committed, thanks! (Don't think that code was actually used though, was it?)

 2006-03-27  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Tommi Myöhänen  <ext-tommi dot myohanen at nokia dot com>

        * ext/gnomevfs/gstgnomevfssrc.c: (gst_gnome_vfs_src_finalize),
        (gst_gnome_vfs_src_get_icy_metadata):
          Fix some minor memory leaks (#336194).