After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336178 - Export to folder: export tag icons
Export to folder: export tag icons
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
0.1.10
Other All
: Normal enhancement
: ---
Assigned To: F-spot maintainers
F-spot maintainers
: 350283 430206 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-27 12:01 UTC by Jean-Christophe Dubacq
Modified: 2008-06-17 10:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to implement the request (3.83 KB, patch)
2006-03-27 12:03 UTC, Jean-Christophe Dubacq 		none Details | Review
folder-gallery-export-tags.patch (9.16 KB, patch)
2007-09-17 19:56 UTC, Maxxer 		needs-work Details | Review
folder-gallery-export-tag-icons.patch (12.76 KB, patch)
2007-11-24 21:53 UTC, Maxxer 		none Details | Review

Description Jean-Christophe Dubacq 2006-03-27 12:01:17 UTC 
The tags could be exported at the same time as the pictures, so that one can
show which tags were given to which picture. This is limited to HTML static
folders, since original does not seem to support (in its design) adding tags.
Patch included. Currently, there is no way to choose whether the tags should be
included (read: with the patch, they are always included). It could be an option
to the export folder dialog.
Comment 1 Jean-Christophe Dubacq 2006-03-27 12:03:39 UTC 
Created attachment 62111 [details] [review]
Patch to implement the request

Nb: patch works against 0.1.10+cvs for src/FolderExport.cs+patch for bug 329685+patch for bug 335935.

Should be only line-fuzz without these patches. They are mainly independant
Comment 2 Stephane Delcroix 2006-08-08 09:38:28 UTC 
*** Bug 350283 has been marked as a duplicate of this bug. ***
Comment 3 Maxxer 2007-09-12 21:12:25 UTC 
http://bugzilla.gnome.org/show_bug.cgi?id=430206 is a duplicate of this bug.

Stephane, if the patch is valid, I'll update to current SVN.
Comment 4 Stephane Delcroix 2007-09-13 08:30:24 UTC 
*** Bug 430206 has been marked as a duplicate of this bug. ***
Comment 5 Stephane Delcroix 2007-09-13 08:35:11 UTC 
it may be good... but exporting tags should be optional
Comment 6 Maxxer 2007-09-17 19:56:39 UTC 
Created attachment 95759 [details] [review]
folder-gallery-export-tags.patch

This patch integrates Jean-Christophe's code to enable tags export on html galleries. Applies to latest SVN.
(OT) I've also added missing accelerated key for "Autorotate".

But I've made a mistake in #3. 430206 is not a duplicate of this :-) pardon...
Comment 7 Bengt Thuree 2007-11-22 19:22:14 UTC 
The patch applies, and compiles.

But, I can not get this patch to work as advertised.

Export to folder - Orig   - No Tags  --> strings indicate Tags
Export to folder - Orig   - Tags     --> strings indicate Tags
Export to folder - Resize - No Tags  --> strings indicate NO tags 
Export to folder - Resize - Tags     --> strings indicate NO tags
Comment 8 Maxxer 2007-11-24 21:53:58 UTC 
Created attachment 99592 [details] [review]
folder-gallery-export-tag-icons.patch

Fixed minor aesthetic issues, like function description in the gui. 

The problem reported by Bengt (dropping tags on resized export) is another
issue and will be fixed in another bug.
I'll update bug summary to better reflect the function.
Comment 9 Maxxer 2008-06-17 10:58:48 UTC 
Patch merged with bug 538543 and committed as r4069.